From 4709cbbed39f0b4d279dfa4ceb08cac56ad90cff Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Oct 2013 12:04:18 +0200 Subject: [PATCH 1/6] [prep-release-3.1.0-a1] Update version to 3.1.0-a1 --- build/build.xml | 2 +- phpBB/includes/constants.php | 2 +- phpBB/install/convertors/convert_phpbb20.php | 2 +- phpBB/install/schemas/schema_data.sql | 2 +- phpBB/styles/prosilver/style.cfg | 4 ++-- phpBB/styles/subsilver2/style.cfg | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/build/build.xml b/build/build.xml index 063f1017fb..4b8fc0e18f 100644 --- a/build/build.xml +++ b/build/build.xml @@ -2,7 +2,7 @@ - + diff --git a/phpBB/includes/constants.php b/phpBB/includes/constants.php index ae55a71e50..5165463969 100644 --- a/phpBB/includes/constants.php +++ b/phpBB/includes/constants.php @@ -24,7 +24,7 @@ if (!defined('IN_PHPBB')) */ // phpBB Version -define('PHPBB_VERSION', '3.1.0-dev'); +define('PHPBB_VERSION', '3.1.0-a1'); // QA-related // define('PHPBB_QA', 1); diff --git a/phpBB/install/convertors/convert_phpbb20.php b/phpBB/install/convertors/convert_phpbb20.php index 4532ecb609..c861028b47 100644 --- a/phpBB/install/convertors/convert_phpbb20.php +++ b/phpBB/install/convertors/convert_phpbb20.php @@ -33,7 +33,7 @@ $dbms = phpbb_convert_30_dbms_to_31($dbms); $convertor_data = array( 'forum_name' => 'phpBB 2.0.x', 'version' => '1.0.3', - 'phpbb_version' => '3.1.0-dev', + 'phpbb_version' => '3.1.0-a1', 'author' => 'phpBB Group', 'dbms' => $dbms, 'dbhost' => $dbhost, diff --git a/phpBB/install/schemas/schema_data.sql b/phpBB/install/schemas/schema_data.sql index 094a43c8a0..0aa84a7610 100644 --- a/phpBB/install/schemas/schema_data.sql +++ b/phpBB/install/schemas/schema_data.sql @@ -270,7 +270,7 @@ INSERT INTO phpbb_config (config_name, config_value) VALUES ('tpl_allow_php', '0 INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_icons_path', 'images/upload_icons'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_path', 'files'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('use_system_cron', '0'); -INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.1.0-dev'); +INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.1.0-a1'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_expire_days', '90'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_gc', '14400'); diff --git a/phpBB/styles/prosilver/style.cfg b/phpBB/styles/prosilver/style.cfg index 633079e4a6..aac9d993f5 100644 --- a/phpBB/styles/prosilver/style.cfg +++ b/phpBB/styles/prosilver/style.cfg @@ -18,8 +18,8 @@ # General Information about this style name = prosilver copyright = © phpBB Group, 2007 -style_version = 3.1.0-dev -phpbb_version = 3.1.0-dev +style_version = 3.1.0-a1 +phpbb_version = 3.1.0-a1 # Defining a different template bitfield # template_bitfield = lNg= diff --git a/phpBB/styles/subsilver2/style.cfg b/phpBB/styles/subsilver2/style.cfg index ca81337d17..1d50352885 100644 --- a/phpBB/styles/subsilver2/style.cfg +++ b/phpBB/styles/subsilver2/style.cfg @@ -18,8 +18,8 @@ # General Information about this style name = subsilver2 copyright = © 2005 phpBB Group -style_version = 3.1.0-dev -phpbb_version = 3.1.0-dev +style_version = 3.1.0-a1 +phpbb_version = 3.1.0-a1 # Defining a different template bitfield # template_bitfield = lNg= From a953a65b6c9e657c9c32a30c738a2822bbca3e09 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Oct 2013 12:08:00 +0200 Subject: [PATCH 2/6] [prep-release-3.1.0-a1] Update changelog with 3.1.0-a1 changes --- phpBB/docs/CHANGELOG.html | 722 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 701 insertions(+), 21 deletions(-) diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html index 2be63eb866..3df124d89f 100644 --- a/phpBB/docs/CHANGELOG.html +++ b/phpBB/docs/CHANGELOG.html @@ -46,6 +46,7 @@
  1. Changelog
      +
    1. Changes since 3.0.x
    2. Changes since 3.0.11
    3. Changes since 3.0.10
    4. Changes since 3.0.9
      5. @@ -86,7 +87,686 @@
      -

      1.i. Changes since 3.0.11

      +

      1.i. Changes since 3.0.x

      + +

      Bug

      +
        +
      • [PHPBB3-4412] - MCP and viewtopic messed up when long profile fields used
        • +
      • [PHPBB3-6109] - MSN is now called Windows Live Messenger (WLM)
        • +
      • [PHPBB3-6855] - The word separator has been misspelled in the code
        • +
      • [PHPBB3-7070] - Making Font Type & Size Easy To modify
        • +
      • [PHPBB3-7252] - Use IMAGETYPE_ constants in get_supported_image_types()
        • +
      • [PHPBB3-7448] - Module management calling non-static method p_master::module_auth()
        • +
      • [PHPBB3-8212] - Comment spelling mistake in includes/acp/acp_board.php
        • +
      • [PHPBB3-8228] - Coding BBcode has whitespace before the code.
        • +
      • [PHPBB3-8542] - No custom profile fields in private messages
        • +
      • [PHPBB3-8641] - Extra and missing comma in acp_board.php
        • +
      • [PHPBB3-8713] - trimming login inputs isn't sensible
        • +
      • [PHPBB3-8841] - Unexpected results when using "PHPBB_USE_BOARD_URL_PATH"
        • +
      • [PHPBB3-8912] - phpbb_styles_template_data contans more than 4k records
        • +
      • [PHPBB3-9022] - Poll Deletion Problem on Global change
        • +
      • [PHPBB3-9163] - style.php cannot be properly cached
        • +
      • [PHPBB3-9341] - Incorrectly named template vars
        • +
      • [PHPBB3-9394] - wrong comment in functions_upload.php
        • +
      • [PHPBB3-9474] - Unnecessary mcp_viewlogs.html included
        • +
      • [PHPBB3-9492] - Group avatar overwrites currently defined user avatars
        • +
      • [PHPBB3-9766] - phpbb_default_captcha::delete_code() takes no argument but uses $confirm_id
        • +
      • [PHPBB3-9918] - $redirect variable set, but not used, in mcp functions
        • +
      • [PHPBB3-10006] - phpbb_config::delete is missing
        • +
      • [PHPBB3-10013] - Cache test writes to a temporary location deep in the source tree
        • +
      • [PHPBB3-10045] - Database updater version for changes between 3.0.x and 3.1.0 should be 3.1.0-dev
        • +
      • [PHPBB3-10070] - CRLF in develop
        • +
      • [PHPBB3-10080] - request_var tests fail when other tests using request_var are executed first
        • +
      • [PHPBB3-10103] - Fix remaining usage of flock() by converting it to use the lock class
        • +
      • [PHPBB3-10136] - Missing $request globalizations in includes/functions.php
        • +
      • [PHPBB3-10139] - Use of $cache for two different things in includes/config/db.php
        • +
      • [PHPBB3-10151] - Version number needs to be updated in installer
        • +
      • [PHPBB3-10152] - Installer places ?> in config.php
        • +
      • [PHPBB3-10156] - Cron tests fail on windows
        • +
      • [PHPBB3-10290] - Who's online broken due to malformed SQL
        • +
      • [PHPBB3-10300] - Groups teampage legends settings
        • +
      • [PHPBB3-10316] - Inconsistency between prosilver and subsilver when locking a topic while moving
        • +
      • [PHPBB3-10322] - No longer possible to include templates via variables, captcha broken
        • +
      • [PHPBB3-10329] - Function pcre_utf8_support() needs the "phpbb_" prefix
        • +
      • [PHPBB3-10350] - class phpbb_template_renderer_eval does not work
        • +
      • [PHPBB3-10355] - Template tests do not correctly end output buffering
        • +
      • [PHPBB3-10359] - Fix phpbb_request regression in download/file.php and style.php
        • +
      • [PHPBB3-10360] - search_results.html gone haywire!
        • +
      • [PHPBB3-10364] - ACP Permissions Roles Tabs Broken
        • +
      • [PHPBB3-10371] - $user->theme['imageset_path'] - doesn't exist anymore
        • +
      • [PHPBB3-10374] - Template cache viewer broken
        • +
      • [PHPBB3-10375] - Template Cache keeps regenerating cache files
        • +
      • [PHPBB3-10378] - Errors in imageset -> theme conversion
        • +
      • [PHPBB3-10380] - Imageset removal: bidi padding change
        • +
      • [PHPBB3-10384] - 1_DAY language variables are not working in templates anymore
        • +
      • [PHPBB3-10392] - Alternate nested block loop syntax broken for auto variables
        • +
      • [PHPBB3-10393] - Syntax error in cached template code
        • +
      • [PHPBB3-10409] - Running database_update.php multiple times breaks the update
        • +
      • [PHPBB3-10417] - phpbb_test_case_helpers::get_test_config() uses array_merge() on undefined $config
        • +
      • [PHPBB3-10444] - Edit reason remains if a post gets edited by a moderator for the second time
        • +
      • [PHPBB3-10457] - Undefined variable $request, when print-viewing PMs
        • +
      • [PHPBB3-10458] - Invalid html when print-viewing a PM
        • +
      • [PHPBB3-10459] - Make "Reply to all"on PMs as a button
        • +
      • [PHPBB3-10463] - Inherit template causes SQL error
        • +
      • [PHPBB3-10464] - Debug error in search settings/search index
        • +
      • [PHPBB3-10477] - Registration, forgot password broken
        • +
      • [PHPBB3-10481] - Test suite does not run on php 5.3
        • +
      • [PHPBB3-10495] - Tests have version checks against php 6.0.0
        • +
      • [PHPBB3-10500] - Miscellaneous issues in the new template engine
        • +
      • [PHPBB3-10541] - Empty "Select form:" dropdown when editing user
        • +
      • [PHPBB3-10547] - Log out instead of acp statistics page at the end of fresh install
        • +
      • [PHPBB3-10560] - Post count not updated to include unapproved posts (though topic count is) for moderators
        • +
      • [PHPBB3-10575] - UCP Register: Non-static method phpbb_captcha_factory::get_instance() should not be called statically
        • +
      • [PHPBB3-10579] - New license block has v2 duplicated
        • +
      • [PHPBB3-10602] - A bug in mail queue processing
        • +
      • [PHPBB3-10618] - Hardcoded phpBB 3.0 language in installer
        • +
      • [PHPBB3-10634] - cp modules: function loaded() only checks current module type
        • +
      • [PHPBB3-10636] - cache_moderators() generates invalid query
        • +
      • [PHPBB3-10637] - Extension manager: missed code changes in search
        • +
      • [PHPBB3-10641] - MCP still uses old plurality forms of language variables
        • +
      • [PHPBB3-10645] - Invalid CSS for checkboxes and radio buttons in ACP css
        • +
      • [PHPBB3-10652] - Template inheritance doesn't work
        • +
      • [PHPBB3-10655] - Bug in test case: phpbb_template_template_inheritance_test
        • +
      • [PHPBB3-10663] - Extension manager: finder class adds directories that should not match the query
        • +
      • [PHPBB3-10667] - Fix extensions and group positions tests under MySQL 5.5 strict mode
        • +
      • [PHPBB3-10671] - Integrity tests failing
        • +
      • [PHPBB3-10672] - Statistics .. Total posts
        • +
      • [PHPBB3-10678] - Provide Firebird, Oracle, and increased MSSQL support in unit tests
        • +
      • [PHPBB3-10685] - Template inheritance test produces a notice on php 5.4 due to an incompatible override of setup_engine
        • +
      • [PHPBB3-10690] - Undefined language string in MCP
        • +
      • [PHPBB3-10703] - extensions.php script dies miserably when ext directory is missing
        • +
      • [PHPBB3-10704] - Typo in a comment
        • +
      • [PHPBB3-10735] - Incorrect styles search order, locator's inability to use template inheritance for extensions
        • +
      • [PHPBB3-10736] - Composer is making tests fail
        • +
      • [PHPBB3-10742] - Tables in users list have incorrect width
        • +
      • [PHPBB3-10752] - acp_styles errors
        • +
      • [PHPBB3-10754] - $style should be renamed to $phpbb_style
        • +
      • [PHPBB3-10756] - Template classes don't belong in style directory
        • +
      • [PHPBB3-10759] - Database updater doesn't reset default style
        • +
      • [PHPBB3-10777] - Typo in viewtopic.php comment line 1632
        • +
      • [PHPBB3-10778] - Extra space on the link "Close Window" in prosilver/template/posting_smilies.html
        • +
      • [PHPBB3-10779] - "Serve jQuery using Google's CDN" Should be on ACP Load Settings, not Board Features
        • +
      • [PHPBB3-10781] - Quick Mod tools don't work
        • +
      • [PHPBB3-10784] - Do not show ajax overlay unless needed
        • +
      • [PHPBB3-10785] - Illegal use of $_REQUEST in develop/fill.php
        • +
      • [PHPBB3-10801] - Move topic in quickmod tools not functional
        • +
      • [PHPBB3-10802] - Splitting topics in quickmod tools not functional
        • +
      • [PHPBB3-10803] - When ajax requests fail, the failure message should remain visible until the user dismisses it
        • +
      • [PHPBB3-10805] - "Request timed out" ui appears over function ui in ajax
        • +
      • [PHPBB3-10807] - Deleting topics via quickmod provides no feedback
        • +
      • [PHPBB3-10808] - Locking topics via quickmod provides no feedback
        • +
      • [PHPBB3-10811] - AJAX callback "alt_text" insufficiently changes links
        • +
      • [PHPBB3-10813] - Installer does not check that php json extension is present
        • +
      • [PHPBB3-10818] - Global Announcements Update Dialog does not terminate with exit_handler()
        • +
      • [PHPBB3-10826] - 3.1-dev Database Updater keeps running group_legend query
        • +
      • [PHPBB3-10837] - Undefined index in extension tests
        • +
      • [PHPBB3-10844] - Extensions are not located when front-end file has a diffferent phpbb_root_path
        • +
      • [PHPBB3-10845] - Reported post text does not get bbcode-parsed when viewing a post report
        • +
      • [PHPBB3-10847] - Dependent is misspelled a number of times
        • +
      • [PHPBB3-10871] - In "Posts awaiting approval" if there's more than one post it shows no posts
        • +
      • [PHPBB3-10875] - SQL Cache is not used
        • +
      • [PHPBB3-10876] - Xampp crashes on Develop when template has too many ORs in an IF statement
        • +
      • [PHPBB3-10885] - UCP Main Error if no forums exist
        • +
      • [PHPBB3-10888] - cachepath in template class is set externally
        • +
      • [PHPBB3-10905] - Last topic title missing in subsilver
        • +
      • [PHPBB3-10906] - Last post title does not work for new installs of 3.1-dev due to missing change to schema_data.sql
        • +
      • [PHPBB3-10912] - Undefined variable: last_post_subject_truncated
        • +
      • [PHPBB3-10915] - Sort not installed styles list in admin control panel - styles
        • +
      • [PHPBB3-10943] - Search Box should display keywords entered by the user
        • +
      • [PHPBB3-10954] - Mark topics as read AJAX
        • +
      • [PHPBB3-10976] - Running tests using phpunit.xml.all fails
        • +
      • [PHPBB3-10982] - Allow setting dimming control overlay also as data-overlay
        • +
      • [PHPBB3-10998] - No border-radius for forum rules block
        • +
      • [PHPBB3-10999] - Asset version not defined in adm/
        • +
      • [PHPBB3-11002] - Etc/GMT timezones return wrong offset
        • +
      • [PHPBB3-11003] - Ability to show full list of timezones with JavaScript enabled
        • +
      • [PHPBB3-11004] - The timezone suggestion button is not a real button
        • +
      • [PHPBB3-11007] - Timezone selector shows all timezones
        • +
      • [PHPBB3-11014] - Previous/next links are no longer displayed.
        • +
      • [PHPBB3-11018] - Pagination in memberlist
        • +
      • [PHPBB3-11023] - Fix excess tabbing and spacing in functions.php
        • +
      • [PHPBB3-11029] - Cannot break/continue 1 level in includes\cache\service.php:340
        • +
      • [PHPBB3-11041] - global $php_ext instead of global $phpEx
        • +
      • [PHPBB3-11043] - Update template hook name
        • +
      • [PHPBB3-11046] - No border-radius for UCP message colours block
        • +
      • [PHPBB3-11047] - Unclosed variable shows incorrect language key
        • +
      • [PHPBB3-11052] - Search class changes not reflected in installer or convertor
        • +
      • [PHPBB3-11065] - li tag on topic display options at MCP is unclosed
        • +
      • [PHPBB3-11067] - Pagination in ACP is missing CSS code from pagination change
        • +
      • [PHPBB3-11077] - Feed still has fallback code for global announcement with forum_id = 0
        • +
      • [PHPBB3-11086] - Database Updater still relies on cache factory - needs to be updated to use DIC
        • +
      • [PHPBB3-11089] - Database type mysql sets unusable board
        • +
      • [PHPBB3-11092] - phpbb_gen_download_links strict standards errors
        • +
      • [PHPBB3-11095] - Jumpbox should use "get" method
        • +
      • [PHPBB3-11099] - Clicking Banning tab in MCP causes all tabs to collapse down
        • +
      • [PHPBB3-11100] - jabber::can_use_ssl() should not be called statically in includes/acp/acp_jabber.php on line 124
        • +
      • [PHPBB3-11101] - Container processors are executed before globals exist
        • +
      • [PHPBB3-11106] - Undefined index: EDITED_TIME_TOTAL
        • +
      • [PHPBB3-11139] - Colour swatch window with Fatal error
        • +
      • [PHPBB3-11140] - MCP Front errors on reported posts
        • +
      • [PHPBB3-11154] - Unable to upgrade 3.0 QI-installed board to 3.1
        • +
      • [PHPBB3-11157] - Strict spam renders spambot countermeasures page unusable
        • +
      • [PHPBB3-11159] - Coding guidelines: static public
        • +
      • [PHPBB3-11166] - AJAX confirm box is not using custom templates given
        • +
      • [PHPBB3-11171] - Copy bbcode fields, etc. for reported posts
        • +
      • [PHPBB3-11176] - Functional tests do not run
        • +
      • [PHPBB3-11177] - Postgres search when query has only negation
        • +
      • [PHPBB3-11187] - Functional tests broken by new config class
        • +
      • [PHPBB3-11188] - postgres search result count does not get the total count
        • +
      • [PHPBB3-11190] - Functional tests do not clear the cache between each test
        • +
      • [PHPBB3-11194] - PHP Notice: Undefined index "tag"
        • +
      • [PHPBB3-11198] - AJAX move up/down links not replaced correctly
        • +
      • [PHPBB3-11199] - Cache purge should remove dumped container
        • +
      • [PHPBB3-11200] - Container construction fails with non-MySQLi drivers
        • +
      • [PHPBB3-11204] - Wrong indentation in functional test case base class
        • +
      • [PHPBB3-11205] - Merge conflict in readme.html
        • +
      • [PHPBB3-11206] - Avatars are broken, includes non-existent files
        • +
      • [PHPBB3-11208] - Functional tests are broken
        • +
      • [PHPBB3-11209] - Always clone Ajax disable images to avoid problems if they are used multiple times on the same page
        • +
      • [PHPBB3-11211] - Call to undefined function phpbb_real_path() in /phpBB/includes/di/extension/ext.php on line 52
        • +
      • [PHPBB3-11212] - Catch non-existent globals if error occurs during container construction
        • +
      • [PHPBB3-11213] - Missing global in install_update.php
        • +
      • [PHPBB3-11227] - @return void -> @return null
        • +
      • [PHPBB3-11236] - Prune users requires group selection if any groups are defined
        • +
      • [PHPBB3-11237] - php spam when pruning users
        • +
      • [PHPBB3-11247] - php spam in flock class
        • +
      • [PHPBB3-11248] - CRLF line endings
        • +
      • [PHPBB3-11253] - Signature module acl is not going to be added to 3.1 boards
        • +
      • [PHPBB3-11256] - Unused service controller.route_collection
        • +
      • [PHPBB3-11257] - Using Service Collection requires set_name() method to exist
        • +
      • [PHPBB3-11263] - PHP Notice: in file functions_messenger.php on line 213: Undefined variable: extension_manager
        • +
      • [PHPBB3-11273] - Missing space after Sphinx "Indexer memory limit" input box
        • +
      • [PHPBB3-11277] - User DST column is not removed on update, and therefor user_timezone is updated everytime the update file is run
        • +
      • [PHPBB3-11279] - "Something went wrong when processing your request." is not acceptable language
        • +
      • [PHPBB3-11291] - "Could not open input file: ../composer.phar" error during phing's create-package
        • +
      • [PHPBB3-11298] - ACP_EXTENSIONS_MANAGEMENT missing string
        • +
      • [PHPBB3-11302] - No timezone is selected by default in registration form
        • +
      • [PHPBB3-11303] - Timezone selection is not preserved in registration form
        • +
      • [PHPBB3-11305] - Installer is broken on develop
        • +
      • [PHPBB3-11309] - phpbb_extension_interface::disable_step correct docblock
        • +
      • [PHPBB3-11310] - CSRF in style installation in acp
        • +
      • [PHPBB3-11311] - Include javascript core.js file in subsilver2 overall_footer.html
        • +
      • [PHPBB3-11313] - Typo in alt_text callback breaks replacement of text
        • +
      • [PHPBB3-11320] - Database test cases fail if functions file is not included and config file exists
        • +
      • [PHPBB3-11321] - Recreate schema files with develop/create_schema_files.php
        • +
      • [PHPBB3-11323] - Not possible to define template variable with other variables
        • +
      • [PHPBB3-11329] - Color values should be in colours.css, not buttons.css
        • +
      • [PHPBB3-11334] - Controller helper url() method still generates URLs like app.php/route/to/page instead of app.php?controller=route/to/page
        • +
      • [PHPBB3-11335] - Hook finder fails to load hooks
        • +
      • [PHPBB3-11342] - Marking subforums as read does not change the unread icons of active topics
        • +
      • [PHPBB3-11344] - ACP_STYLE_COMPONENTS
        • +
      • [PHPBB3-11345] - Font size on new buttons is too thin
        • +
      • [PHPBB3-11350] - $db should not be passed by reference to db_tools
        • +
      • [PHPBB3-11362] - Resource locator does not find admin template files from extensions
        • +
      • [PHPBB3-11363] - Migrations module tool does not load info files from extensions
        • +
      • [PHPBB3-11367] - Migrator throws error if migrations table does not exist
        • +
      • [PHPBB3-11369] - Reverting migration throws error (attempt to unserialize string)
        • +
      • [PHPBB3-11370] - Effectively installed migrations not inserted into migrations table
        • +
      • [PHPBB3-11372] - Migrator should only check if effectively installed if the migration is not installed at all
        • +
      • [PHPBB3-11381] - Finder cannot find items for non-enabled extensions (required during installation)
        • +
      • [PHPBB3-11383] - Uninstalling an extension that adds a module causes an error upon purge
        • +
      • [PHPBB3-11385] - get_module_infos from migrator does not return module info
        • +
      • [PHPBB3-11386] - Migrator can include files multiple times
        • +
      • [PHPBB3-11387] - Module add tool logs module as added even if it fails due to error (migrations)
        • +
      • [PHPBB3-11388] - Extension CSS files are not being auto-loaded
        • +
      • [PHPBB3-11394] - Migration Tools are too strict
        • +
      • [PHPBB3-11395] - acp_modules::get_module_infos can include files multiple times
        • +
      • [PHPBB3-11396] - insert_migration also updates migration (should rename function)
        • +
      • [PHPBB3-11398] - Migrations permission tool's method permission_set causes fatal error
        • +
      • [PHPBB3-11400] - Notification system assumes email is always available
        • +
      • [PHPBB3-11402] - Undefined offset 0 post/topic_in_queue (notifications)
        • +
      • [PHPBB3-11403] - Multiinsert for notifications should use batches
        • +
      • [PHPBB3-11404] - Can not access ACP "manage group" page while creating new groups
        • +
      • [PHPBB3-11405] - Users that are subscribed to a forum, don't receive notifications for new replies
        • +
      • [PHPBB3-11407] - UI notifications have wrong <dfn> info next to checkbox
        • +
      • [PHPBB3-11408] - Undefined index jabber (should be user_jabber)
        • +
      • [PHPBB3-11411] - Broken primary key on phpbb_notification_types table
        • +
      • [PHPBB3-11413] - phpbb_notification_types table should have an integer primary key
        • +
      • [PHPBB3-11415] - Accessing phpbb_migrations table from index page (or other pages)
        • +
      • [PHPBB3-11416] - Primary key on phpbb_notifications table too small
        • +
      • [PHPBB3-11417] - Notification Options page in User Control Panel has "Mark read" as submit button.
        • +
      • [PHPBB3-11420] - Notification methods are not (correctly) imported
        • +
      • [PHPBB3-11421] - Submit button missing from UCP notifications module
        • +
      • [PHPBB3-11422] - Assets should be incremented on database update
        • +
      • [PHPBB3-11423] - Email has HTML from username
        • +
      • [PHPBB3-11433] - Loading alert message is shown beneath overlay
        • +
      • [PHPBB3-11435] - Extension template files curly braces bug
        • +
      • [PHPBB3-11437] - Sphinx debug assert failed when no search results are found
        • +
      • [PHPBB3-11438] - Sphinx default config does not work properly
        • +
      • [PHPBB3-11439] - Notification tests are not run via phpunit.xml.dist
        • +
      • [PHPBB3-11440] - Mixed type (string vs integer) in SQL query against phpbb_users
        • +
      • [PHPBB3-11442] - AJAX in the ACP Does not work wherever Confirm Box modals are used
        • +
      • [PHPBB3-11443] - Two migration tests are not run via phpunit.xml.dist
        • +
      • [PHPBB3-11448] - phpbb_notification_manager::mark_notifications_read takes $user_id as a parameter but isn't using it
        • +
      • [PHPBB3-11450] - phpbb_extension_metadata_manager has wrong docs and too many arguments
        • +
      • [PHPBB3-11451] - class phpbb_notification_method_jabber extends phpbb_notification_method_email
        • +
      • [PHPBB3-11452] - phpbb_notification_method_email::is_available() should return false when user doesn't have an email address
        • +
      • [PHPBB3-11454] - Jabber notifications are not working at all
        • +
      • [PHPBB3-11455] - Sort phpBB/config/tables.yml in alphabetic order
        • +
      • [PHPBB3-11457] - class phpbb_notification_test should not require/use the global set_var() function
        • +
      • [PHPBB3-11460] - New installs have wrong data in phpbb_user_notifications table.
        • +
      • [PHPBB3-11464] - Config table load_cpf_pm is missing on new install
        • +
      • [PHPBB3-11466] - phpunit configs excludes non-existant files
        • +
      • [PHPBB3-11471] - Some email templates contain unrelated text
        • +
      • [PHPBB3-11474] - "Post in queue" notification send to too many moderators
        • +
      • [PHPBB3-11478] - Daylight Savingtime changes old posts in time, too.
        • +
      • [PHPBB3-11479] - Can not access install/index.php?mode=update
        • +
      • [PHPBB3-11485] - migration doesn't add necessary columns to phpbb_styles table when updating schemas.
        • +
      • [PHPBB3-11488] - Notification email error
        • +
      • [PHPBB3-11489] - Change forum list layout to work at any resolution
        • +
      • [PHPBB3-11491] - Functional test for extensions has wrong class name and is in the wrong directory
        • +
      • [PHPBB3-11492] - memberlist user_ids array uninitalized can lead to error
        • +
      • [PHPBB3-11494] - Fix memberlist leaders functional tests
        • +
      • [PHPBB3-11501] - Fix "This test did not perform any assertions" message on some tests
        • +
      • [PHPBB3-11503] - Implementation of DB drivers vary too much
        • +
      • [PHPBB3-11516] - .live() deprecated in new version of jquery
        • +
      • [PHPBB3-11535] - ACP und UCP avatar groups settings do not display an error upon submitting incorrect data
        • +
      • [PHPBB3-11549] - Resource locator does not find admin template files from extensions
        • +
      • [PHPBB3-11550] - Functional extension controller test should use $helpers to copy and remove files
        • +
      • [PHPBB3-11551] - ACP System tab errors: [phpBB Debug] - PHP Notice: in file [ROOT] -/includes/acp/acp_update.php on line 49: Undefined offset: 1
        • +
      • [PHPBB3-11553] - Links list errors
        • +
      • [PHPBB3-11554] - forum_fn.js should be moved to footer
        • +
      • [PHPBB3-11555] - Pagination page selection JS is broken
        • +
      • [PHPBB3-11556] - Remove non-jquery fallback code from forum_fn.js
        • +
      • [PHPBB3-11560] - Missing T_JQUERY_LINK template variable in installer
        • +
      • [PHPBB3-11561] - Notification functional tests fail using phpunit.xml.all
        • +
      • [PHPBB3-11562] - forum_fn.js cleanup
        • +
      • [PHPBB3-11563] - Move subPanels() code from html templates to forum_fn.js
        • +
      • [PHPBB3-11564] - Notifications list errors
        • +
      • [PHPBB3-11567] - Fatal error at database update
        • +
      • [PHPBB3-11569] - Database update fails at continuing on some environments
        • +
      • [PHPBB3-11570] - No way to get back to update routine when in database updater
        • +
      • [PHPBB3-11573] - Test Suite does not work with MySQL STRICT_TRANS_TABLES (MySQL 5.6)
        • +
      • [PHPBB3-11574] - Unable to "auto update" from 3.0 to 3.1
        • +
      • [PHPBB3-11585] - Strict Standars error when editing the role
        • +
      • [PHPBB3-11586] - Fix/cleanup some of upload_attachment()'s code
        • +
      • [PHPBB3-11587] - Group gets removed from legend when editing one in UCP
        • +
      • [PHPBB3-11593] - filter->compile_var_tags uses undefined variable
        • +
      • [PHPBB3-11594] - Template filter not aware of extension context
        • +
      • [PHPBB3-11599] - Tree tests are very slow
        • +
      • [PHPBB3-11602] - Do not call avatar_manager's localize_errors() if avatars are disabled
        • +
      • [PHPBB3-11605] - Order of files and directories given to phpbb_test_case_helpers->remove_files() matters.
        • +
      • [PHPBB3-11622] - Template events are loaded incorrectly
        • +
      • [PHPBB3-11647] - URLs are incorrectly handled by INCLUDEJS
        • +
      • [PHPBB3-11660] - Bootstrap container from config.php bugs
        • +
      • [PHPBB3-11664] - Creating php.html file in root path in tests
        • +
      • [PHPBB3-11665] - Can't change file names already sent to set_filenames
        • +
      • [PHPBB3-11675] - Uncaught exception 'Twig_Error_Syntax' -Permissions User roles-
        • +
      • [PHPBB3-11687] - assets_version is missing in phpbb_config
        • +
      • [PHPBB3-11688] - Cache purge does not purge the twig directory
        • +
      • [PHPBB3-11691] - Soft delete migration conversion should be staggered
        • +
      • [PHPBB3-11692] - Don't update search_type in dev migration if already appended with phpbb_search_
        • +
      • [PHPBB3-11694] - Twig Error on ACP Login page
        • +
      • [PHPBB3-11695] - Cannot edit first post in a topic more than once without manually changing "Options Per User" to 1 on second edit.
        • +
      • [PHPBB3-11696] - phpbb_db_tools does not autoload
        • +
      • [PHPBB3-11697] - fulltext_mysql.php - author_search() uses incorrect $m_approve_fid_ary parameter
        • +
      • [PHPBB3-11701] - TWIG breaks template events for events inside of looped template code
        • +
      • [PHPBB3-11702] - Forumlink gives general error
        • +
      • [PHPBB3-11706] - getimagesize() should be called with @ to prevent PHP warning in remote avatar
        • +
      • [PHPBB3-11707] - Twig DEFINE not working as expected
        • +
      • [PHPBB3-11708] - Invalid bulletin point in notifications
        • +
      • [PHPBB3-11712] - Typo in editor.js
        • +
      • [PHPBB3-11713] - Module gets removed by ajax even if removal was not successful
        • +
      • [PHPBB3-11717] - View unanswered posts = General error
        • +
      • [PHPBB3-11718] - Twig lexer only correcting statements in IF, not ELSEIF
        • +
      • [PHPBB3-11723] - Can not agree to Terms of Service if more than one language is installed
        • +
      • [PHPBB3-11725] - No Avatar image -upload avatar-
        • +
      • [PHPBB3-11727] - INCLUDECSS and INCLUDEJS incorrectly default to /template/ folder
        • +
      • [PHPBB3-11728] - Fix last occurance of topic_approved index
        • +
      • [PHPBB3-11729] - memberlist.php is empty white page
        • +
      • [PHPBB3-11731] - Make calls for captcha garbage collections non-static
        • +
      • [PHPBB3-11733] - Illegal offset type Warning in [ROOT] -/includes/auth/auth.php via [ROOT] -/feed.php
        • +
      • [PHPBB3-11734] - Missing permession in language file
        • +
      • [PHPBB3-11735] - Missing checkbox in User Control Panel / Manage notifications
        • +
      • [PHPBB3-11739] - Wrong name for UCP Module "Edit "Remember Me" login keys"
        • +
      • [PHPBB3-11741] - Brackets exist even without any text
        • +
      • [PHPBB3-11751] - MCP Softdelete Modules missing when updating board
        • +
      • [PHPBB3-11754] - Remove leftovers of style switcher
        • +
      • [PHPBB3-11755] - MySQL Upgrader out of date for 3.1
        • +
      • [PHPBB3-11757] - Typo in signature_module_auth migration
        • +
      • [PHPBB3-11759] - Migrations update to the wrong 3.0.x version numbers.
        • +
      • [PHPBB3-11761] - Example.org no longer serves blank responses, failing functional tests
        • +
      • [PHPBB3-11763] - Debug and SQL Error when reporting a PM
        • +
      • [PHPBB3-11767] - Unable to update DB from 3.0.X to 3.1.X because of post_visibility
        • +
      • [PHPBB3-11770] - Invalid class for pm list in outbox/sentbox
        • +
      • [PHPBB3-11774] - PHP errors on viewing reported post details
        • +
      • [PHPBB3-11777] - Extension template events are not loaded from subdirectories
        • +
      • [PHPBB3-11779] - Invalid class for unapproved posts in mcp index
        • +
      • [PHPBB3-11780] - Remove unused images from prosilver
        • +
      • [PHPBB3-11781] - update_post_information() is not defined in phpbb_content_visibility->set_post_visibility
        • +
      • [PHPBB3-11782] - Notices inside posts look messy
        • +
      • [PHPBB3-11791] - Template events are not loaded in ACP
        • +
      • [PHPBB3-11792] - core.user_setup event doesn't support loading language files from extensions
        • +
      • [PHPBB3-11796] - Duplicate code for pagination
        • +
      • [PHPBB3-11800] - Incorrect inclusion of scripts in popup window
        • +
      • [PHPBB3-11804] - </li> tag at overall_header.html (prosilver) which was not open
        • +
      • [PHPBB3-11805] - pagination does not support controller_helper urls
        • +
      • [PHPBB3-11809] - core.js should be loaded directly after jQuery and after every other JS file
        • +
      • [PHPBB3-11811] - Chrome 30 adds outline to focused elements
        • +
      • [PHPBB3-11812] - No longer able to define empty template variable using DEFINE
        • +
      • [PHPBB3-11816] - Twig regression: parentheses in IF statements stop DEFINE variables and loop lengths from working
        • +
      • [PHPBB3-11822] - Template include asset doesn't follow namespace lookup order
        • +
      • [PHPBB3-11824] - Controller URLs do not work anymore
        • +
      • [PHPBB3-11825] - phpBB/phpbb/ should only contain classes
        • +
      • [PHPBB3-11828] - Twig DEFINE is causing errors
        • +
      • [PHPBB3-11832] - URLs in tests aren't shortened, triggering errors in Composer files
        • +
      • [PHPBB3-11833] - Twig error while viewing user notes
        • +
      • [PHPBB3-11835] - phpbb_db_migration_data_310_auth_provider_oauth: A required module does not exist: UCP_AUTH_LINK
        • +
      • [PHPBB3-11836] - Manage external account associations error
        • +
      • [PHPBB3-11837] - UCP_AUTH_LINK_NOT_SUPPORTED (untranslated)
        • +
      • [PHPBB3-11843] - Regression: using underscores in template DEFINE variables yields unexpected behavior
        • +
      • [PHPBB3-11846] - Empty paragraph elements in jumpbox.html
        • +
      • [PHPBB3-11850] - $user->page contains bogus data on controller (app.php) pages
        • +
      • [PHPBB3-11852] - filesystem class must not depend on a web request
        • +
      • [PHPBB3-11862] - Events core.delete_user_before and core.delete_user_after compact the wrong vars
        • +
      • [PHPBB3-11865] - includes/bbcode.php is missing namespace change
        • +
      • [PHPBB3-11866] - "You have specified an invalid dbms driver" Error with config sample
        • +
      • [PHPBB3-11867] - Schema files are not created by create_schema_files.php
        • +
      • [PHPBB3-11868] - Class 'phpbb_request_interface' not found
        • +
      • [PHPBB3-11871] - Extension modules are not working with namespaces anymore
        • +
      • [PHPBB3-11874] - RSS Feed -Bug Url-
        • +
      • [PHPBB3-11878] - Missing leading \ in dependencies in soft_delete_mcp_modules
        • +
      • [PHPBB3-11882] - Incorrect dependency in signature module auth migration
        • +
      • [PHPBB3-11888] - On New installation the default search backend is not shown correctly.
        • +
      • [PHPBB3-11890] - Language key used when soft-deleting in MCP.
        • +
      • [PHPBB3-11892] - Undefined variable: to_forum_id after cancelling merge topic/move posts
        • +
      • [PHPBB3-11893] - Font size in "Edit 'Remember Me' login keys" is large
        • +
      • [PHPBB3-11895] - Forum feed stopped working
        • +
      • [PHPBB3-11898] - Unable to login to ACP on AREA51
        • +
      • [PHPBB3-11901] - Undefined offset: 3 in file [ROOT] -/includes/functions_content.php on line 776
        • +
      • [PHPBB3-11905] - Alpha 1 Migration
        • +
      • [PHPBB3-11906] - Missing database entries "read_notification"
        • +
      • [PHPBB3-11908] - class phpbb_auth_provider_oauth_service_exception not using namespaces
        • +
      +

      Improvement

      +
        +
      • [PHPBB3-7598] - Reminding inactive users
        • +
      • [PHPBB3-7938] - Display information about unread and new PMs in the header.
        • +
      • [PHPBB3-8065] - Add an option to lock topics while moving them.
        • +
      • [PHPBB3-8270] - Automatically loaded language-files for mods
        • +
      • [PHPBB3-8796] - Mark forum(s) read (or mark topics read) marks some topics you haven't read
        • +
      • [PHPBB3-9346] - Use different message template for jabber notification
        • +
      • [PHPBB3-9532] - Optimized Page Titles
        • +
      • [PHPBB3-9549] - Enhance teampage functionality
        • +
      • [PHPBB3-9596] - Modular cron and allowing cron tasks to be run from system cron
        • +
      • [PHPBB3-9608] - Cleanse object references from codebase for 3.1
        • +
      • [PHPBB3-9649] - Moderator queue does not display icon if the new post is made in old thread
        • +
      • [PHPBB3-9668] - Automatic UTF-8 normalization
        • +
      • [PHPBB3-9669] - Native UTF-8 normalization
        • +
      • [PHPBB3-9684] - Link global announcements to forums
        • +
      • [PHPBB3-9693] - generate_smilies clean up
        • +
      • [PHPBB3-9716] - Handle user input through a request class providing a more complete mechanism than request_var
        • +
      • [PHPBB3-9741] - Do not store any themes or templates in the database
        • +
      • [PHPBB3-9746] - Normalise internet protocol version 6 addresses
        • +
      • [PHPBB3-9792] - Move function definitions out of download/file.php
        • +
      • [PHPBB3-9823] - Move functions definitions out of adm/index.php
        • +
      • [PHPBB3-9979] - Autoloading for test suite
        • +
      • [PHPBB3-10001] - Class Based Forum/Topic Image
        • +
      • [PHPBB3-10076] - STARTTLS for emails
        • +
      • [PHPBB3-10143] - Delete-write-read test for config classes
        • +
      • [PHPBB3-10148] - Turn TEMPLATE_BITFIELD into an instance variable in acp_styles.php
        • +
      • [PHPBB3-10155] - Inclusion of jQuery
        • +
      • [PHPBB3-10161] - Use one of "email" or "e-mail"
        • +
      • [PHPBB3-10172] - Display empty birthday box in prosilver when birthdays are enabled but there are none today
        • +
      • [PHPBB3-10258] - Use HTML5 doctype
        • +
      • [PHPBB3-10271] - confirm_box operations should use AJAX
        • +
      • [PHPBB3-10272] - Simple operations should use AJAX
        • +
      • [PHPBB3-10273] - Accepting / denying posts should use AJAX
        • +
      • [PHPBB3-10281] - Reordering forums in the ACP should use AJAX
        • +
      • [PHPBB3-10312] - Un-check "Leave shadow topic in place" checkbox when moving topics
        • +
      • [PHPBB3-10325] - Ability to disable the "I forgot my password" feature
        • +
      • [PHPBB3-10336] - Removing imagesets in 3.1
        • +
      • [PHPBB3-10344] - Add attachment icons to list of reports and queue
        • +
      • [PHPBB3-10362] - HTML5 Fix - "name" attribute is deprecated in anchors. Use "id" attribute instead.
        • +
      • [PHPBB3-10383] - Polls should use AJAX
        • +
      • [PHPBB3-10387] - generate_pagination() should export the current page number as a template variable
        • +
      • [PHPBB3-10390] - Add an ACP option to use jQuery via local copy or remote CDN
        • +
      • [PHPBB3-10410] - Add option to display users in their first teampage group
        • +
      • [PHPBB3-10412] - Use memory_get_peak_usage for debug output instead of memory_get_usage
        • +
      • [PHPBB3-10431] - Remove language from the button-graphics and use text strings instead
        • +
      • [PHPBB3-10438] - Alligning the Smileys on the same line as the text.
        • +
      • [PHPBB3-10484] - Use variables for sql_build_query() calls, so mods/extensions can extend the arrays
        • +
      • [PHPBB3-10510] - Quick-mod markup should be in the template
        • +
      • [PHPBB3-10524] - Wrong version code name in Ascraeus coding guidelines document.
        • +
      • [PHPBB3-10535] - Remove "Confirm Email Address" field from registration form
        • +
      • [PHPBB3-10557] - Missing IN_PHPBB check in phpBB/includes/functions_acp.php
        • +
      • [PHPBB3-10601] - Move inbox to top module in UCP Private Messages Tab
        • +
      • [PHPBB3-10614] - Script to manage extensions
        • +
      • [PHPBB3-10617] - prosilver clean up: adding proper css reset
        • +
      • [PHPBB3-10619] - prosilver clean up: removing duplicate colors
        • +
      • [PHPBB3-10632] - Merging style components
        • +
      • [PHPBB3-10640] - Bigger Topic Title Length
        • +
      • [PHPBB3-10650] - Last Topic Title on Forum list
        • +
      • [PHPBB3-10659] - Allow all administrators to purge cache
        • +
      • [PHPBB3-10665] - INCLUDEJS template tag
        • +
      • [PHPBB3-10679] - Add new permission for changing profile field information
        • +
      • [PHPBB3-10705] - Replace WARNINGS_ZERO_TOTAL with NO_WARNINGS for consistency
        • +
      • [PHPBB3-10714] - Create a class for add_log() and unit tests
        • +
      • [PHPBB3-10726] - Preview from Quick Reply
        • +
      • [PHPBB3-10727] - Don't hide quickreply with javascript
        • +
      • [PHPBB3-10733] - Adding file locator function to style class
        • +
      • [PHPBB3-10734] - CSS3 rounded corners
        • +
      • [PHPBB3-10741] - Automatically resize textarea
        • +
      • [PHPBB3-10743] - Change theme to style in php code
        • +
      • [PHPBB3-10762] - Separate style and phpBB version numbers in style.cfg
        • +
      • [PHPBB3-10771] - Using Remember Me instead of autologin or persistent keys in the UI.
        • +
      • [PHPBB3-10780] - Move colons from template files to language files
        • +
      • [PHPBB3-10783] - assets_version config var appended to assets (css/js) URLs to prevent caching
        • +
      • [PHPBB3-10786] - Render search options by default on memberlist.php
        • +
      • [PHPBB3-10799] - includejs should not put phpbb root path in generated template code
        • +
      • [PHPBB3-10800] - includejs test confusingly includes an html file
        • +
      • [PHPBB3-10864] - Allow extensions to be accessed via controller with shorter access name than "vendor/extname"
        • +
      • [PHPBB3-10933] - Make style code more understandable
        • +
      • [PHPBB3-10936] - MySQL fulltext search improvement - removing check for PCRE UTF support
        • +
      • [PHPBB3-10938] - Display subforum listing on forumlist via template loop instead of PHP implode()
        • +
      • [PHPBB3-10947] - Quickmod tools have stopped autosubmitting
        • +
      • [PHPBB3-10955] - ajaxify should take options as the only argument
        • +
      • [PHPBB3-10966] - Remove code duplication from mysql* and mssql* dbal
        • +
      • [PHPBB3-10968] - Render pagination fully within the template
        • +
      • [PHPBB3-10970] - Allow INCLUDE template macros to accept paths of the form {FOO}/a/{BAR}/c
        • +
      • [PHPBB3-10972] - Add a new method to phpbb_functional_test_case to allow a new user to be created
        • +
      • [PHPBB3-10973] - Allow mocks to be autoloaded in tests
        • +
      • [PHPBB3-10975] - Memberlist functional tests
        • +
      • [PHPBB3-10990] - $user->lang['COMMA_SEPARATOR'] - is not uniformly used
        • +
      • [PHPBB3-11001] - html5 Placeholder for search box.
        • +
      • [PHPBB3-11008] - Get rid of eval in javascript
        • +
      • [PHPBB3-11010] - HTML5 input types for form fields
        • +
      • [PHPBB3-11011] - Using dependency injection for global variables in all search backends.
        • +
      • [PHPBB3-11012] - Member variable phpEx vs php_ext naming inconstistency
        • +
      • [PHPBB3-11013] - Allow arrays to be assigned and retrieved in templates
        • +
      • [PHPBB3-11015] - Make DBAL classes autoloadable
        • +
      • [PHPBB3-11021] - Link back to main site config setting
        • +
      • [PHPBB3-11025] - Make Last topic title in forum list Bold
        • +
      • [PHPBB3-11032] - Better error reporting for sphinx
        • +
      • [PHPBB3-11037] - Cache drivers require globals
        • +
      • [PHPBB3-11044] - Compress class should keep track of files added and deal with conflicts
        • +
      • [PHPBB3-11048] - Use access specifiers in search backends
        • +
      • [PHPBB3-11050] - Add docblocks missing in properties and methods in all search backends.
        • +
      • [PHPBB3-11051] - Add retrieval functions for all public properties in search backends
        • +
      • [PHPBB3-11068] - Hiding foes posts should use JS to display them, rather then reloading the whole page
        • +
      • [PHPBB3-11070] - Redundant background-position property in Prosilver button CSS?
        • +
      • [PHPBB3-11082] - Redis cache driver should not have executable permission
        • +
      • [PHPBB3-11083] - Abstract cache drivers should use abstract keyword
        • +
      • [PHPBB3-11088] - Combine Style and Extension Management into one Customisations tab in the ACP
        • +
      • [PHPBB3-11116] - Adjust Display of Warning/Error Messages in Extensions Controller
        • +
      • [PHPBB3-11129] - Misleading subscription state messages
        • +
      • [PHPBB3-11152] - Create cached, compiled container class rather than compiling it on every page load
        • +
      • [PHPBB3-11156] - Delete "Misc" tab of forum based permissions + move items
        • +
      • [PHPBB3-11174] - Unit tests for search backends
        • +
      • [PHPBB3-11181] - Bump PHP requirement to 5.3.3
        • +
      • [PHPBB3-11183] - Remove $load_extensions and weird dl() calls
        • +
      • [PHPBB3-11189] - Merge DEBUG and DEBUG_EXTRA
        • +
      • [PHPBB3-11193] - Generalize phpbb_di_pass_collection_pass to handle all collections using service tags
        • +
      • [PHPBB3-11197] - Prefix the css classes for the small arrow with "arrow".
        • +
      • [PHPBB3-11202] - Add response status checks to functional tests
        • +
      • [PHPBB3-11215] - Separate root path for filesystem and urls/assets
        • +
      • [PHPBB3-11217] - Prefix for template values to give back value URL encoded
        • +
      • [PHPBB3-11238] - Specify goutte version
        • +
      • [PHPBB3-11250] - Remake the unit tests for the BBCode parser.
        • +
      • [PHPBB3-11259] - Make $phpbb_admin_path available everywhere
        • +
      • [PHPBB3-11268] - Delete phpbb_db_driver_mysql4 case
        • +
      • [PHPBB3-11275] - editor.js::colorPalette() breaks page with document.write > add proper target
        • +
      • [PHPBB3-11283] - Extensions as symlinks
        • +
      • [PHPBB3-11294] - Update extension list in running tests doc
        • +
      • [PHPBB3-11306] - Container should be created by a phpbb_create_default_container() function
        • +
      • [PHPBB3-11314] - Improve readability and code cleanup in new JavaScript files
        • +
      • [PHPBB3-11328] - New language variables for buttons
        • +
      • [PHPBB3-11373] - Notifications - Purge old with cron
        • +
      • [PHPBB3-11390] - Remove pagination from ucp_notifications.html when list is empty.
        • +
      • [PHPBB3-11393] - Give more information on database_updater about what exactly happened
        • +
      • [PHPBB3-11409] - No feedback provided when updating group position settings in ACP
        • +
      • [PHPBB3-11458] - Automatically add extension permission language files
        • +
      • [PHPBB3-11461] - [Template Event] - viewtopic_body_footer
        • +
      • [PHPBB3-11463] - Add topic title attribute in search results
        • +
      • [PHPBB3-11477] - Allow customisation of "Board index"
        • +
      • [PHPBB3-11482] - Extend syntax for DEFINE tag
        • +
      • [PHPBB3-11495] - Add nested sets implementation to phpBB core
        • +
      • [PHPBB3-11519] - Rename test event template file
        • +
      • [PHPBB3-11533] - Notification settings page is using topiclist class incorrectly
        • +
      • [PHPBB3-11557] - Allow to use tab when typing code and keep indentation
        • +
      • [PHPBB3-11558] - Notifications link in header should not include [ and ] -
        • +
      • [PHPBB3-11577] - Topiclist/Forumlist Needs tweaking after PR 1331
        • +
      • [PHPBB3-11582] - Split permission logic from translations
        • +
      • [PHPBB3-11600] - Increase code test coverage of avatar manager
        • +
      • [PHPBB3-11606] - make_clickable() in includes/functions_content.php uses deprecated preg_replace() /e modifier (PREG_REPLACE_EVAL)
        • +
      • [PHPBB3-11615] - Partial refactoring of session tests
        • +
      • [PHPBB3-11620] - Improve session test coverage
        • +
      • [PHPBB3-11621] - Improve MySQL fulltext search indexes
        • +
      • [PHPBB3-11651] - Bootstrap container from config.php
        • +
      • [PHPBB3-11667] - phpbb_template_twig_node_includeasset should be abstract
        • +
      • [PHPBB3-11669] - Fix PHP bug #55124 (/./ in recursive mkdirs)
        • +
      • [PHPBB3-11684] - No utility to time-wasting user login confirmation message/screen
        • +
      • [PHPBB3-11685] - No utility to time-wasting user logout confirmation message/screen
        • +
      • [PHPBB3-11700] - Use namespaces rather than prefixes for class names
        • +
      • [PHPBB3-11703] - Make "Serve jQuery using Google’s CDN" generic
        • +
      • [PHPBB3-11724] - Support "ELSE IF" and "ELSEIF" in the same way
        • +
      • [PHPBB3-11744] - Group join request notification
        • +
      • [PHPBB3-11745] - Group join approved notification
        • +
      • [PHPBB3-11747] - UCP Prefs Core and Template Events
        • +
      • [PHPBB3-11749] - PHP and Template Event Requests for Topic Preview Extension
        • +
      • [PHPBB3-11784] - Remove naming redundancy for event listeners
        • +
      • [PHPBB3-11786] - Fix various defects in PHPDoc in-code documentation
        • +
      • [PHPBB3-11795] - Move all JavaScript from HTML code to external files
        • +
      • [PHPBB3-11813] - Mock authentication provider should implement base provider class
        • +
      • [PHPBB3-11831] - Update fabpot/goutte to 1.0.*
        • +
      +

      New Feature

      + +

      Sub-task

      +
        +
      • [PHPBB3-9556] - Drop php closing tags
        • +
      • [PHPBB3-9574] - Drop fallback implementations
        • +
      • [PHPBB3-9688] - update_session API
        • +
      • [PHPBB3-9738] - Make installer and updater use migrations
        • +
      • [PHPBB3-9797] - Adjust existing access to superglobals
        • +
      • [PHPBB3-10817] - Use valid composer.json instead of non-standard extension.json
        • +
      • [PHPBB3-10992] - Use updated Goutte in Fileupload tests
        • +
      • [PHPBB3-11109] - Create a separate set of compress tests for the develop branch
        • +
      • [PHPBB3-11243] - Topics with attachments only show "download all attachments" links on pages containing attachments.
        • +
      • [PHPBB3-11318] - Extensions use migrations
        • +
      • [PHPBB3-11351] - Add appropriate language strings for errors
        • +
      • [PHPBB3-11531] - Add functional tests for new avatar system
        • +
      • [PHPBB3-11637] - generate_text_for_display on search.php
        • +
      • [PHPBB3-11638] - generate_text_for_display on viewtopic.php
        • +
      • [PHPBB3-11639] - generate_text_for_display on includes/functions_posting.php
        • +
      • [PHPBB3-11640] - generate_text_for_display on includes/functions_privmsgs.php
        • +
      • [PHPBB3-11641] - generate_text_for_display on includes/mcp/mcp_pm_reports.php
        • +
      • [PHPBB3-11642] - generate_text_for_display on includes/mcp/mcp_post.php
        • +
      • [PHPBB3-11643] - generate_text_for_display on includes/mcp/mcp_queue.php
        • +
      • [PHPBB3-11653] - generate_text_for_display on includes/mcp/mcp_topic.php
        • +
      • [PHPBB3-11654] - generate_text_for_display on includes/mcp/mcp_warn.php
        • +
      • [PHPBB3-11655] - generate_text_for_display on includes/ucp/ucp_pm_viewmessage.php
        • +
      • [PHPBB3-11656] - generate_text_for_display on memberlist.php
        • +
      +

      Task

      +
        +
      • [PHPBB3-7090] - Update minimum PHP version to 5.2
        • +
      • [PHPBB3-9557] - Update coding guidelines for 3.1 and PHP >= 5.2
        • +
      • [PHPBB3-9682] - Add a class loader for auto loading and define naming rules for new phpbb classes
        • +
      • [PHPBB3-9783] - Restore subsilver2
        • +
      • [PHPBB3-9867] - Adjust the implementation of error messages localization
        • +
      • [PHPBB3-9983] - Restructure ACM classes
        • +
      • [PHPBB3-9988] - Replace config with an instance of a class implementing ArrayAccess
        • +
      • [PHPBB3-10091] - Bump minimum required postgresql version for 3.1
        • +
      • [PHPBB3-10173] - Move birthday list logic into templates
        • +
      • [PHPBB3-10202] - Provide a mechanism to manually retrieve long configuration options from a TEXT column
        • +
      • [PHPBB3-10260] - Remove prosilver styleswitcher
        • +
      • [PHPBB3-10314] - Whitelist all files in includes for code coverage reports
        • +
      • [PHPBB3-10389] - JSON extension should be checked in the installer
        • +
      • [PHPBB3-10414] - Functional testing
        • +
      • [PHPBB3-10467] - Check extensions diff for classes/constants not existing in php 5.2
        • +
      • [PHPBB3-10609] - Prefix phpBB functions with phpbb_ to prevent compatibility issues with other software
        • +
      • [PHPBB3-10670] - Require PHP 5.3 at minimum for phpBB 3.1
        • +
      • [PHPBB3-10680] - Add ext/ to .gitignore
        • +
      • [PHPBB3-10688] - Change 3.0 language to 3.1
        • +
      • [PHPBB3-10693] - Change minimum PHP version for Ascraeus to 5.3.2
        • +
      • [PHPBB3-10719] - Remove second 5.2 test suite on ascreaus
        • +
      • [PHPBB3-10732] - Add config_dev.php and config_test.php to .gitignore
        • +
      • [PHPBB3-10855] - Coding guideline change - have curly brackets on same line in JS
        • +
      • [PHPBB3-10869] - Remove PHP 5.2 check from .travis.yml
        • +
      • [PHPBB3-10877] - Have bamboo generate and publish a phpBB package for every build.
        • +
      • [PHPBB3-10882] - Expand test coverage for template engine - add tests for invalid constructs
        • +
      • [PHPBB3-10893] - Update the Usage of Composer
        • +
      • [PHPBB3-10909] - Update Travis Test Configuration: Travis no longer supports PHP 5.3.2
        • +
      • [PHPBB3-10932] - Store composer.phar in the phpBB repository to make sure a working version is always available
        • +
      • [PHPBB3-10939] - Modify the phpbb_request class to handle the $_FILES superglobal as well
        • +
      • [PHPBB3-10941] - Write tests for includes/functions_upload.php
        • +
      • [PHPBB3-10944] - Allow INCLUDEJS to include javascript from the assets directory
        • +
      • [PHPBB3-10949] - 3.1 AJAX code should use new coding guidelines
        • +
      • [PHPBB3-10963] - Use fileinfo in filespec::is_image() instead of trusting the mimetype sent by the browser
        • +
      • [PHPBB3-10969] - Remove remove_comments() and remove_remarks()
        • +
      • [PHPBB3-10993] - Update README to use composer.phar from the repository
        • +
      • [PHPBB3-10994] - Revert changes in PHPBB3-10963
        • +
      • [PHPBB3-11054] - Improper @var documentation syntax in includes/extension/controller.php
        • +
      • [PHPBB3-11061] - Fix README composer instructions
        • +
      • [PHPBB3-11195] - Put conditional opening brace on its own line, as per guidelines
        • +
      • [PHPBB3-11225] - Delete subsilver2 mcp_jumpbox.html
        • +
      • [PHPBB3-11287] - Add Template Event naming guidelines to docs/coding-guidelines.html
        • +
      • [PHPBB3-11338] - Enable Redis tests on Travis
        • +
      • [PHPBB3-11441] - Refactor phpbb_user_loader tests
        • +
      • [PHPBB3-11476] - Remove pass-by-reference from phpbb_db_driver::sql_multi_insert
        • +
      • [PHPBB3-11481] - Feed classes are currently all in feed.php
        • +
      • [PHPBB3-11698] - Move all autoloadable files to phpbb/ rather than includes/
        • +
      • [PHPBB3-11722] - Remove reference assignment for $captcha in report.php
        • +
      • [PHPBB3-11760] - 3.0.x Migration should use the phpbb_version_compare() wrapper.
        • +
      • [PHPBB3-11818] - Upgrade Symfony to 2.3 LTS
        • +
      • [PHPBB3-11870] - No longer exclude ./phpBB/phpbb/search/fulltext_*.php from code coverage
        • +
      • [PHPBB3-11885] - Add migrations for 3.0.12-RCx and 3.0.12
        • +
      • [PHPBB3-11913] - Apply reorganisation of download.phpbb.com to build_announcement.php
        • +
      + +

      1.ii. Changes since 3.0.11

      Bug

        @@ -241,7 +921,7 @@
      • [PHPBB3-11753] - Upgrade mysql_upgrader.php schema data.
      -

      1.ii. Changes since 3.0.10

      +

      1.iii. Changes since 3.0.10

      Bug

        @@ -366,7 +1046,7 @@
      • [PHPBB3-10909] - Update Travis Test Configuration: Travis no longer supports PHP 5.3.2
      -

      1.iii. Changes since 3.0.9

      +

      1.iv. Changes since 3.0.9

      Bug

        @@ -502,7 +1182,7 @@
      • [PHPBB3-10480] - Automate changelog building
      -

      1.iv. Changes since 3.0.8

      +

      1.v. Changes since 3.0.8

      Bug

      @@ -870,7 +1550,7 @@ -

      1.v. Changes since 3.0.7-PL1

      +

      1.vi. Changes since 3.0.7-PL1

      Security

        @@ -1328,13 +2008,13 @@
      -

      1.vi. Changes since 3.0.7

      +

      1.vii. Changes since 3.0.7

      • [Sec] Do not expose forum content of forums with ACL entries but no actual permission in ATOM Feeds. (Bug #58595)
      -

      1.vii. Changes since 3.0.6

      +

      1.viii. Changes since 3.0.6

      • [Fix] Allow ban reason and length to be selected and copied in ACP and subsilver2 MCP. (Bug #51095)
        • @@ -1438,7 +2118,7 @@
      -

      1.viii. Changes since 3.0.5

      +

      1.ix. Changes since 3.0.5

      • [Fix] Allow whitespaces in avatar gallery names. (Bug #44955)
        • @@ -1660,7 +2340,7 @@
      • [Feature] Send anonymous statistical information to phpBB on installation and update (optional).
      -

      1.ix. Changes since 3.0.4

      +

      1.x. Changes since 3.0.4

      • [Fix] Delete user entry from ban list table upon user deletion (Bug #40015 - Patch by TerraFrost)
        • @@ -1749,7 +2429,7 @@
      • [Sec] Only use forum id supplied for posting if global announcement detected. (Reported by nickvergessen)
      -

      1.x. Changes since 3.0.3

      +

      1.xi. Changes since 3.0.3

      • [Fix] Allow mixed-case template directories to be inherited (Bug #36725)
        • @@ -1781,7 +2461,7 @@
      • [Sec] Ask for forum password if post within passworded forum quoted in private message. (Reported by nickvergessen)
      -

      1.xi. Changes since 3.0.2

      +

      1.xii. Changes since 3.0.2

      • [Fix] Correctly set topic starter if first post in topic removed (Bug #30575 - Patch by blueray2048)
        • @@ -1880,7 +2560,7 @@
      • [Sec Precaution] Stricter validation of the HTTP_HOST header (Thanks to Techie-Micheal et al for pointing out possible issues in derived code)
      -

      1.xii. Changes since 3.0.1

      +

      1.xiii. Changes since 3.0.1

      • [Fix] Ability to set permissions on non-mysql dbms (Bug #24955)
        • @@ -1928,7 +2608,7 @@
      • [Sec] Only allow urls gone through redirect() being used within login_box(). (thanks nookieman)
      -

      1.xiii Changes since 3.0.0

      +

      1.xiv Changes since 3.0.0

      • [Change] Validate birthdays (Bug #15004)
        • @@ -1999,7 +2679,7 @@
      • [Fix] Find and display colliding usernames correctly when converting from one database to another (Bug #23925)
      -

      1.xiv. Changes since 3.0.RC8

      +

      1.xv. Changes since 3.0.RC8

      • [Fix] Cleaned usernames contain only single spaces, so "a_name" and "a__name" are treated as the same name (Bug #15634)
        • @@ -2008,7 +2688,7 @@
      • [Fix] Call garbage_collection() within database updater to correctly close connections (affects Oracle for example)
      -

      1.xv. Changes since 3.0.RC7

      +

      1.xvi. Changes since 3.0.RC7

      • [Fix] Fixed MSSQL related bug in the update system
        • @@ -2043,7 +2723,7 @@
      • [Fix] No duplication of active topics (Bug #15474)
      -

      1.xvi. Changes since 3.0.RC6

      +

      1.xvii. Changes since 3.0.RC6

      • [Fix] Submitting language changes using acp_language (Bug #14736)
        • @@ -2053,7 +2733,7 @@
      • [Fix] Able to request new password (Bug #14743)
      -

      1.xvii. Changes since 3.0.RC5

      +

      1.xviii. Changes since 3.0.RC5

      • [Feature] Removing constant PHPBB_EMBEDDED in favor of using an exit_handler(); the constant was meant to achive this more or less.
        • @@ -2116,7 +2796,7 @@
      • [Sec] New password hashing mechanism for storing passwords (#i42)
      -

      1.xviii. Changes since 3.0.RC4

      +

      1.xix. Changes since 3.0.RC4

      • [Fix] MySQL, PostgreSQL and SQLite related database fixes (Bug #13862)
        • @@ -2167,7 +2847,7 @@
      • [Fix] odbc_autocommit causing existing result sets to be dropped (Bug #14182)
      -

      1.xix. Changes since 3.0.RC3

      +

      1.xx. Changes since 3.0.RC3

      • [Fix] Fixing some subsilver2 and prosilver style issues
        • @@ -2276,7 +2956,7 @@
      -

      1.xx. Changes since 3.0.RC2

      +

      1.xxi. Changes since 3.0.RC2

      • [Fix] Re-allow searching within the memberlist
        • @@ -2322,7 +3002,7 @@
      -

      1.xxi. Changes since 3.0.RC1

      +

      1.xxii. Changes since 3.0.RC1

      • [Fix] (X)HTML issues within the templates (Bug #11255, #11255)
        • From 7a46976a785bd2a89004ecdce69662b2ece2ed4d Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Oct 2013 12:21:54 +0200 Subject: [PATCH 3/6] [prep-release-3.1.0-a1] Only build packages for the latest olympus versions --- build/build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/build.xml b/build/build.xml index 4b8fc0e18f..82bb979a02 100644 --- a/build/build.xml +++ b/build/build.xml @@ -4,7 +4,7 @@ - + From 76ddf1ca4143f38f3bf8fc6aabdb3fa302d6ed40 Mon Sep 17 00:00:00 2001 From: Patrick Webster Date: Mon, 14 Oct 2013 16:37:23 -0500 Subject: [PATCH 4/6] [ticket/11918] Make sql_freeresult() consistent across all DB drivers PHPBB3-11918 --- phpBB/phpbb/db/driver/firebird.php | 2 +- phpBB/phpbb/db/driver/mssql.php | 6 +++--- phpBB/phpbb/db/driver/mssql_odbc.php | 2 +- phpBB/phpbb/db/driver/mssqlnative.php | 3 ++- phpBB/phpbb/db/driver/mysql.php | 2 +- phpBB/phpbb/db/driver/oracle.php | 2 +- phpBB/phpbb/db/driver/postgres.php | 2 +- phpBB/phpbb/db/driver/sqlite.php | 2 +- 8 files changed, 11 insertions(+), 10 deletions(-) diff --git a/phpBB/phpbb/db/driver/firebird.php b/phpBB/phpbb/db/driver/firebird.php index 2df5eaf369..aef75eab15 100644 --- a/phpBB/phpbb/db/driver/firebird.php +++ b/phpBB/phpbb/db/driver/firebird.php @@ -398,7 +398,7 @@ class firebird extends \phpbb\db\driver\driver $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } diff --git a/phpBB/phpbb/db/driver/mssql.php b/phpBB/phpbb/db/driver/mssql.php index 4d2cd287da..50096deded 100644 --- a/phpBB/phpbb/db/driver/mssql.php +++ b/phpBB/phpbb/db/driver/mssql.php @@ -318,14 +318,14 @@ class mssql extends \phpbb\db\driver\driver $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } - if (isset($this->open_queries[$query_id])) + if (isset($this->open_queries[(int) $query_id])) { - unset($this->open_queries[$query_id]); + unset($this->open_queries[(int) $query_id]); return @mssql_free_result($query_id); } diff --git a/phpBB/phpbb/db/driver/mssql_odbc.php b/phpBB/phpbb/db/driver/mssql_odbc.php index 9db34a69fb..b9881035c0 100644 --- a/phpBB/phpbb/db/driver/mssql_odbc.php +++ b/phpBB/phpbb/db/driver/mssql_odbc.php @@ -305,7 +305,7 @@ class mssql_odbc extends \phpbb\db\driver\mssql_base $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } diff --git a/phpBB/phpbb/db/driver/mssqlnative.php b/phpBB/phpbb/db/driver/mssqlnative.php index e6002fe1a3..aade311bcb 100644 --- a/phpBB/phpbb/db/driver/mssqlnative.php +++ b/phpBB/phpbb/db/driver/mssqlnative.php @@ -471,7 +471,7 @@ class mssqlnative extends \phpbb\db\driver\mssql_base $query_id = $this->query_result; } - if ($cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } @@ -481,6 +481,7 @@ class mssqlnative extends \phpbb\db\driver\mssql_base unset($this->open_queries[(int) $query_id]); return @sqlsrv_free_stmt($query_id); } + return false; } diff --git a/phpBB/phpbb/db/driver/mysql.php b/phpBB/phpbb/db/driver/mysql.php index c76126763d..d215453ccb 100644 --- a/phpBB/phpbb/db/driver/mysql.php +++ b/phpBB/phpbb/db/driver/mysql.php @@ -289,7 +289,7 @@ class mysql extends \phpbb\db\driver\mysql_base $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } diff --git a/phpBB/phpbb/db/driver/oracle.php b/phpBB/phpbb/db/driver/oracle.php index 5dfab21455..4fba654d1e 100644 --- a/phpBB/phpbb/db/driver/oracle.php +++ b/phpBB/phpbb/db/driver/oracle.php @@ -621,7 +621,7 @@ class oracle extends \phpbb\db\driver\driver $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } diff --git a/phpBB/phpbb/db/driver/postgres.php b/phpBB/phpbb/db/driver/postgres.php index 7a98b90c73..9cbb1ecb07 100644 --- a/phpBB/phpbb/db/driver/postgres.php +++ b/phpBB/phpbb/db/driver/postgres.php @@ -350,7 +350,7 @@ class postgres extends \phpbb\db\driver\driver $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } diff --git a/phpBB/phpbb/db/driver/sqlite.php b/phpBB/phpbb/db/driver/sqlite.php index a548fd2618..55a33284f2 100644 --- a/phpBB/phpbb/db/driver/sqlite.php +++ b/phpBB/phpbb/db/driver/sqlite.php @@ -261,7 +261,7 @@ class sqlite extends \phpbb\db\driver\driver $query_id = $this->query_result; } - if ($cache && $cache->sql_exists($query_id)) + if ($cache && !is_object($query_id) && $cache->sql_exists($query_id)) { return $cache->sql_freeresult($query_id); } From 2b1ee16e4fa859ade2160910c529f59ddd1db697 Mon Sep 17 00:00:00 2001 From: Patrick Webster Date: Mon, 14 Oct 2013 21:18:41 -0500 Subject: [PATCH 5/6] [ticket/11919] Remove extra argument to notification manager's sql_fetchfield() PHPBB3-11919 --- phpBB/phpbb/notification/manager.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/phpBB/phpbb/notification/manager.php b/phpBB/phpbb/notification/manager.php index c42c84fb1f..b92b247c74 100644 --- a/phpBB/phpbb/notification/manager.php +++ b/phpBB/phpbb/notification/manager.php @@ -154,7 +154,7 @@ class manager AND nt.notification_type_id = n.notification_type_id AND nt.notification_type_enabled = 1'; $result = $this->db->sql_query($sql); - $unread_count = (int) $this->db->sql_fetchfield('unread_count', $result); + $unread_count = (int) $this->db->sql_fetchfield('unread_count'); $this->db->sql_freeresult($result); } @@ -167,7 +167,7 @@ class manager AND nt.notification_type_id = n.notification_type_id AND nt.notification_type_enabled = 1'; $result = $this->db->sql_query($sql); - $total_count = (int) $this->db->sql_fetchfield('total_count', $result); + $total_count = (int) $this->db->sql_fetchfield('total_count'); $this->db->sql_freeresult($result); } From a35721f68c95153f46dd67ea465addedf82f538e Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Tue, 15 Oct 2013 15:46:11 +0200 Subject: [PATCH 6/6] [prep-release-3.1.0-a1] Update changelog with the latest changes --- phpBB/docs/CHANGELOG.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html index 3df124d89f..7c96dd1b78 100644 --- a/phpBB/docs/CHANGELOG.html +++ b/phpBB/docs/CHANGELOG.html @@ -477,6 +477,8 @@
      • [PHPBB3-11905] - Alpha 1 Migration
      • [PHPBB3-11906] - Missing database entries "read_notification"
      • [PHPBB3-11908] - class phpbb_auth_provider_oauth_service_exception not using namespaces
        • +
      • [PHPBB3-11918] - Can not update from 3.0.x to 3.1.x with MSSQL
        • +
      • [PHPBB3-11919] - Improper argument order for sql_fetchfield() in notification manager

      Improvement