mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-09 02:06:32 +02:00
Code Issues Releases Wiki Activity

[ticket/16955] Clean up captcha classes

Browse Source 
PHPBB3-16955
This commit is contained in:
Marc Alexander
2022-12-27 16:13:56 +01:00
parent 83cb41e72a
commit 35228ffd62
6 changed files with 22 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
phpBB/phpbb/captcha/plugins/qa.php
View File

@@ -39,6 +39,9 @@ class qa
*/
protected $service_name;
/** @var int Question ID */
protected $question = -1;
/**
* Constructor
*
@@ -450,7 +453,7 @@ class qa
'session_id' => (string) $user->session_id,
'lang_iso' => (string) $this->question_lang,
'confirm_type' => (int) $this->type,
'question_id' => (int) $this->question,
'question_id' => $this->question,
));
$db->sql_query($sql);
@@ -473,7 +476,7 @@ class qa
$this->solved = 0;
$sql = 'UPDATE ' . $this->table_qa_confirm . '
SET question_id = ' . (int) $this->question . "
SET question_id = ' . $this->question . "
WHERE confirm_id = '" . $db->sql_escape($this->confirm_id) . "'
AND session_id = '" . $db->sql_escape($user->session_id) . "'";
$db->sql_query($sql);
@@ -493,7 +496,7 @@ class qa
$this->solved = 0;
$sql = 'UPDATE ' . $this->table_qa_confirm . '
SET question_id = ' . (int) $this->question . ",
SET question_id = ' . $this->question . ",
attempts = attempts + 1
WHERE confirm_id = '" . $db->sql_escape($this->confirm_id) . "'
AND session_id = '" . $db->sql_escape($user->session_id) . "'";
@@ -553,7 +556,7 @@ class qa
if ($row)
{
$this->question = $row['question_id'];
$this->question = (int) $row['question_id'];
$this->attempts = $row['attempts'];
$this->question_strict = $row['strict'];
@@ -576,7 +579,7 @@ class qa
$sql = 'SELECT answer_text
FROM ' . $this->table_captcha_answers . '
WHERE question_id = ' . (int) $this->question;
WHERE question_id = ' . $this->question;
$result = $db->sql_query($sql);
while ($row = $db->sql_fetchrow($result))