1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00

Changed sendpassword so it dosan't deactivate the account

Fixed a security hole in group cp (thanks Ashe)


git-svn-id: file:///svn/phpbb/trunk@1164 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
James Atkinson
2001-10-11 08:03:03 +00:00
parent 2f10b2076e
commit 38d780d1ce
3 changed files with 31 additions and 3 deletions

View File

@@ -40,6 +40,7 @@ if(!isset($HTTP_GET_VARS['start']))
}
$page_title = $lang['Group_Control_Panel'];
$is_moderator = FALSE;
//
// First, joining a group
@@ -157,18 +158,44 @@ else if( isset($HTTP_POST_VARS['unsub']) || isset($HTTP_POST_VARS['unsubpending'
//
else if( isset($HTTP_GET_VARS[POST_GROUPS_URL]) || isset($HTTP_POST_VARS[POST_GROUPS_URL]) )
{
//
// Include page header here because we might need to send a header redirect from the unsub section
//
include($phpbb_root_path . 'includes/page_header.'.$phpEx);
$group_id = ( isset($HTTP_POST_VARS[POST_GROUPS_URL]) ) ? $HTTP_POST_VARS[POST_GROUPS_URL] : $HTTP_GET_VARS[POST_GROUPS_URL];
//
// For security, get the ID of the group moderator.
//
$sql = "SELECT group_moderator FROM " . GROUPS_TABLE . " WHERE group_id = $group_id";
if(!$result = $db->sql_query($sql))
{
message_die(GENERAL_ERROR, "Could not get moderator information", $lang['Error'], __LINE__, __FILE__, $sql);
}
$row = $db->sql_fetchrow($result);
$group_moderator = $row['group_moderator'];
if($group_moderator == $userdata['user_id'] || $userdata['user_level'] == ADMIN)
{
$is_moderator = TRUE;
}
//
// Handle Additions, removals, approvals and denials
//
if(isset($HTTP_POST_VARS['approve']) || isset($HTTP_POST_VARS['deny']) || $HTTP_POST_VARS['add'] || $HTTP_POST_VARS['remove'])
{
if(!$is_moderator)
{
message_die(GENERAL_ERROR, $lang['Not_group_moderator'], $lang['Error']);
}
$members = $HTTP_POST_VARS['member'];
if(isset($HTTP_POST_VARS['add']))
@@ -307,7 +334,7 @@ else if( isset($HTTP_GET_VARS[POST_GROUPS_URL]) || isset($HTTP_POST_VARS[POST_GR
//
// END approve or deny
//
$start = ( isset($HTTP_GET_VARS['start']) ) ? $HTTP_GET_VARS['start'] : 0;