mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

Merge pull request #6324 from rxu/ticket/16908

Browse Source 
[ticket/16908] Fix PHP warning on non-existent post id requests
This commit is contained in:
Marc Alexander
2021-11-30 21:54:09 +01:00
parent 534cef94c9 88a11c1377
commit 39905eaf4b
2 changed files with 28 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/functional/posting_test.php
View File

@@ -300,4 +300,26 @@ class phpbb_functional_posting_test extends phpbb_functional_test_case
$crawler->filter('#preview .content')->html()
);
}
public function nonexistent_post_id_data()
{
$nonexistent_post_id = 999999; // Random value
return [
['edit', $nonexistent_post_id],
['delete', $nonexistent_post_id],
['quote', $nonexistent_post_id],
['soft_delete', $nonexistent_post_id],
];
}
/**
* @dataProvider nonexistent_post_id_data
*/
public function test_nonexistent_post_id($mode, $nonexistent_post_id)
{
$this->add_lang('posting');
$this->login();
$crawler = self::request('GET', "posting.php?mode={$mode}&p={$nonexistent_post_id}&sid={$this->sid}");
$this->assertContainsLang('NO_POST', $crawler->text());
}
}