mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/15699] Avoid magic numbers with constants

Browse Source 
PHPBB3-15699
This commit is contained in:
rubencm
2021-03-21 18:57:18 +01:00
committed by Ruben Calvo
parent 4b46939258
commit 3c4aa6ee8c
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
phpBB/includes/acp/acp_storage.php
View File

@@ -181,7 +181,7 @@ class acp_storage
}
// If update_type is copy or move, copy files from the old to the new storage
if ($this->state['update_type'] >= 1)
if (in_array($this->state['update_type'], [STORAGE_UPDATE_TYPE_COPY, STORAGE_UPDATE_TYPE_MOVE], true))
{
$i = 0;
foreach ($this->state['storages'] as $storage_name => $storage_options)
@@ -228,7 +228,7 @@ class acp_storage
}
// If update_type is move files, remove the old files
if ($this->state['update_type'] == 2)
if ($this->state['update_type'] === STORAGE_UPDATE_TYPE_MOVE)
{
$i = 0;
foreach ($this->state['storages'] as $storage_name => $storage_options)
@@ -355,7 +355,7 @@ class acp_storage
$this->state = [
// Save the value of the checkbox, to remove all files from the
// old storage once they have been successfully moved
'update_type' => $this->request->variable('update_type', 0),
'update_type' => (int) $this->request->variable('update_type', STORAGE_UPDATE_TYPE_CONFIG),
'storage_index' => 0,
'file_index' => 0,
'remove_storage_index' => 0,