mirror of
https://github.com/phpbb/phpbb.git
synced 2025-05-30 02:59:29 +02:00
[ticket/16206] Remove offsetExists and set non-NULL value
PHPBB3-16206
This commit is contained in:
parent
79a6648b99
commit
3e22a2eebd
@ -49,21 +49,6 @@ class service_collection extends \ArrayObject
|
|||||||
return new service_collection_iterator($this);
|
return new service_collection_iterator($this);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Because of a PHP issue we have to redefine offsetExists
|
|
||||||
// (even with a call to the parent):
|
|
||||||
// https://bugs.php.net/bug.php?id=66834
|
|
||||||
// https://bugs.php.net/bug.php?id=67067
|
|
||||||
// But it triggers a sniffer issue that we have to skip
|
|
||||||
// @codingStandardsIgnoreStart
|
|
||||||
/**
|
|
||||||
* {@inheritdoc}
|
|
||||||
*/
|
|
||||||
public function offsetExists($index)
|
|
||||||
{
|
|
||||||
return parent::offsetExists($index);
|
|
||||||
}
|
|
||||||
// @codingStandardsIgnoreEnd
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* {@inheritdoc}
|
* {@inheritdoc}
|
||||||
*/
|
*/
|
||||||
@ -76,11 +61,11 @@ class service_collection extends \ArrayObject
|
|||||||
* Add a service to the collection
|
* Add a service to the collection
|
||||||
*
|
*
|
||||||
* @param string $name The service name
|
* @param string $name The service name
|
||||||
* @return null
|
* @return void
|
||||||
*/
|
*/
|
||||||
public function add($name)
|
public function add($name)
|
||||||
{
|
{
|
||||||
$this->offsetSet($name, null);
|
$this->offsetSet($name, false);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
Loading…
x
Reference in New Issue
Block a user