[ticket/16955] Fix phpdoc annotations and return types

PHPBB3-16955

phpBB/phpbb/db/driver/driver.php

@@ -1246,7 +1246,7 @@ abstract class driver implements driver_interface
 				$this->html_hold .= '<tr>';
 
 				$class = 'row1';
-				foreach (array_values($row) as $val)
+				foreach ($row as $val)
 				{
 					$class = ($class == 'row1') ? 'row2' : 'row1';
 					$this->html_hold .= '<td class="' . $class . '">' . (($val) ? $val : '&nbsp;') . '</td>';

phpBB/phpbb/db/driver/driver_interface.php

@@ -365,7 +365,7 @@ interface driver_interface
 	*
 	* @param	mixed	$query_id	Already executed query result,
 	*								if false, the last query will be used.
-	* @return	null
+	* @return	void
 	*/
 	public function sql_freeresult($query_id = false);
 

phpBB/phpbb/db/driver/oracle.php

@@ -780,8 +780,6 @@ class oracle extends \phpbb\db\driver\driver
 					$success = @oci_execute($result, OCI_DEFAULT);
 					if ($success)
 					{
-						array();
-
 						while ($row = oci_fetch_array($result, OCI_ASSOC + OCI_RETURN_NULLS))
 						{
 							// Take the time spent on parsing rows into account