mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/16955] Clean up installer classes for psalm

Browse Source 
PHPBB3-16955
This commit is contained in:
Marc Alexander
2022-12-26 14:42:23 +01:00
parent d9c179f9ef
commit 40e8a737c3
22 changed files with 54 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
phpBB/phpbb/install/console/command/install/config/show.php
View File

@@ -73,7 +73,7 @@ class show extends \phpbb\console\command\command
* @param InputInterface $input An InputInterface instance
* @param OutputInterface $output An OutputInterface instance
*
* @return null
* @return int 0 if everything went fine, or a non-zero exit code
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
@@ -90,7 +90,7 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message(array('MISSING_FILE', $config_file));
return;
return 1;
}
try
@@ -101,7 +101,7 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message('INVALID_YAML_FILE');
return;
return 1;
}
$processor = new Processor();
@@ -115,9 +115,11 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message('INVALID_CONFIGURATION', $e->getMessage());
return;
return 1;
}
$style->block(Yaml::dump(array('installer' => $config), 10, 4, true, false));
return 0;
}
}

2
phpBB/phpbb/install/console/command/install/config/validate.php
View File

@@ -73,7 +73,7 @@ class validate extends \phpbb\console\command\command
* @param InputInterface $input An InputInterface instance
* @param OutputInterface $output An OutputInterface instance
*
* @return null
* @return int 0 if everything went fine, or a non-zero exit code
*/
protected function execute(InputInterface $input, OutputInterface $output)
{

2
phpBB/phpbb/install/console/command/install/install.php
View File

@@ -92,7 +92,7 @@ class install extends \phpbb\console\command\command
* @param InputInterface $input An InputInterface instance
* @param OutputInterface $output An OutputInterface instance
*
* @return null
* @return int 0 if everything went fine, or a non-zero exit code
*/
protected function execute(InputInterface $input, OutputInterface $output)
{

10
phpBB/phpbb/install/console/command/update/config/show.php
View File

@@ -73,7 +73,7 @@ class show extends \phpbb\console\command\command
* @param InputInterface $input An InputInterface instance
* @param OutputInterface $output An OutputInterface instance
*
* @return null
* @return int 0 if everything went fine, or a non-zero exit code
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
@@ -90,7 +90,7 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message(array('MISSING_FILE', $config_file));
return;
return 1;
}
try
@@ -101,7 +101,7 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message('INVALID_YAML_FILE');
return;
return 1;
}
$processor = new Processor();
@@ -115,9 +115,11 @@ class show extends \phpbb\console\command\command
{
$iohandler->add_error_message('INVALID_CONFIGURATION', $e->getMessage());
return;
return 1;
}
$style->block(Yaml::dump(array('updater' => $config), 10, 4, true, false));
return 0;
}
}

2
phpBB/phpbb/install/console/command/update/config/validate.php
View File

@@ -73,7 +73,7 @@ class validate extends \phpbb\console\command\command
* @param InputInterface $input An InputInterface instance
* @param OutputInterface $output An OutputInterface instance
*
* @return null
* @return int 0 if everything went fine, or a non-zero exit code
*/
protected function execute(InputInterface $input, OutputInterface $output)
{