diff --git a/phpBB/login.php b/phpBB/login.php index f135fbbc5f..15d0d449d2 100644 --- a/phpBB/login.php +++ b/phpBB/login.php @@ -118,23 +118,23 @@ if( isset($HTTP_POST_VARS['login']) || isset($HTTP_GET_VARS['login']) || isset($ WHERE user_id = ' . $row['user_id']; $db->sql_query($sql); } - - $redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : ''; - $redirect = str_replace('?', '&', $redirect); - - if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r")) - { - message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.'); - } - - $template->assign_vars(array( - 'META' => "") - ); - - $message = $lang['Error_login'] . '

' . sprintf($lang['Click_return_login'], "", '') . '

' . sprintf($lang['Click_return_index'], '', ''); - - message_die(GENERAL_MESSAGE, $message); } + + $redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : ''; + $redirect = str_replace('?', '&', $redirect); + + if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r")) + { + message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.'); + } + + $template->assign_vars(array( + 'META' => "") + ); + + $message = $lang['Error_login'] . '

' . sprintf($lang['Click_return_login'], "", '') . '

' . sprintf($lang['Click_return_index'], '', ''); + + message_die(GENERAL_MESSAGE, $message); } } else