mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-06 16:56:44 +02:00
Code Issues Releases Wiki Activity

it has been decided amongst the team that using glob() is bad practice, after determining the overall usage among projects as well as the security history of the function.

Browse Source 
git-svn-id: file:///svn/phpbb/trunk@7900 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Meik Sievertsen
2007-07-17 16:08:42 +00:00
parent cc42f6ed22
commit 484d214ef7
3 changed files with 21 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
phpBB/install/install_update.php
View File

@@ -441,33 +441,19 @@ class install_update extends module
else if (!$recache)
{
$last_change = $theme['theme_mtime'];
$file_list = @glob("{$phpbb_root_path}styles/{$theme['theme_path']}/theme/*.css", GLOB_NOSORT);
$dir = @opendir("{$phpbb_root_path}styles/{$theme['theme_path']}/theme");
if ($file_list === false || $file_list === NULL)
if ($dir)
{
$file_list = array();
$dir = @opendir("{$phpbb_root_path}styles/{$theme['theme_path']}/theme");
if ($dir)
while (($entry = readdir($dir)) !== false)
{
while (($entry = readdir($dir)) !== false)
if (substr(strrchr($entry, '.'), 1) == 'css' && $last_change < @filemtime("{$phpbb_root_path}styles/{$theme['theme_path']}/theme/{$entry}"))
{
if (substr(strrchr($entry, '.'), 1) == 'css')
{
$file_list[] = "{$phpbb_root_path}styles/{$theme['theme_path']}/theme/{$entry}";
}
$recache = true;
break;
}
closedir($dir);
}
}
foreach ($file_list as $file)
{
if ($last_change < @filemtime($file))
{
$recache = true;
break;
}
closedir($dir);
}
}