mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 14:00:31 +02:00
Code Issues Releases Wiki Activity

Cleaning up a little. Mostly there are excellent reasons not to use sql_in_set.

Browse Source 
Might be revisisted in the future.
#13797


git-svn-id: file:///svn/phpbb/trunk@7952 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Henry Sudhof
2007-07-26 11:51:23 +00:00
parent 8a26bac6e2
commit 4dc5afd639
2 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpBB/includes/acp/auth.php
View File

@@ -821,7 +821,7 @@ class auth_admin extends auth
}
// Remove current auth options...
$auth_option_ids = array();
$auth_option_ids = array((int)$any_option_id);
foreach ($auth as $auth_option => $auth_setting)
{
$auth_option_ids[] = (int) $this->option_ids[$auth_option];
@@ -830,7 +830,7 @@ class auth_admin extends auth
$sql = "DELETE FROM $table
WHERE $forum_sql
AND $ug_id_sql
AND auth_option_id IN ($any_option_id, " . implode(', ', $auth_option_ids) . ')';
AND ". $db->sql_in_set(auth_option_id, $auth_option_ids);
$db->sql_query($sql);
// Remove those having a role assigned... the correct type of course...