mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 05:50:42 +02:00
Code Issues Releases Wiki Activity

[ticket/10631] Metadata manager tests

Browse Source 
PHPBB3-10631
This commit is contained in:
Nathan Guse
2012-07-28 14:59:55 -05:00
committed by Unknown Bliss
parent 8c5786636a
commit 500879520c
4 changed files with 424 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
phpBB/includes/extension/metadata_manager.php
View File

@@ -178,36 +178,37 @@ class phpbb_extension_metadata_manager
'version' => '#.+#',
);
if (isset($fields[$name]))
switch ($name)
{
if (!isset($this->metadata[$name]))
{
throw new phpbb_extension_exception("Required meta field '$name' has not been set.");
}
case 'all':
$this->validate('display');
if (!preg_match($fields[$name], $this->metadata[$name]))
{
throw new phpbb_extension_exception("Meta field '$name' is invalid.");
}
}
$this->validate_enable();
break;
// Validate all fields
if ($name == 'all')
{
$this->validate('display');
case 'display':
foreach ($fields as $field => $data)
{
$this->validate($field);
}
$this->validate_enable();
}
$this->validate_authors();
break;
// Validate display fields
if ($name == 'display')
{
foreach ($fields as $field => $data)
{
$this->validate($field);
}
default:
if (isset($fields[$name]))
{
if (!isset($this->metadata[$name]))
{
throw new phpbb_extension_exception("Required meta field '$name' has not been set.");
}
$this->validate_authors();
if (!preg_match($fields[$name], $this->metadata[$name]))
{
throw new phpbb_extension_exception("Meta field '$name' is invalid.");
}
}
break;
}
return true;
@@ -218,7 +219,7 @@ class phpbb_extension_metadata_manager
*
* @return boolean True when passes validation, throws exception if invalid
*/
private function validate_authors()
public function validate_authors()
{
if (empty($this->metadata['authors']))
{
@@ -258,7 +259,7 @@ class phpbb_extension_metadata_manager
*
* @return boolean True when passes validation
*/
private function validate_require_phpbb()
public function validate_require_phpbb()
{
if (!isset($this->metadata['require']['phpbb']))
{
@@ -273,7 +274,7 @@ class phpbb_extension_metadata_manager
*
* @return boolean True when passes validation
*/
private function validate_require_php()
public function validate_require_php()
{
if (!isset($this->metadata['require']['php']))
{