mirror of
https://github.com/phpbb/phpbb.git
synced 2025-07-30 21:40:43 +02:00
[ticket/15531] Log malformed BBCodes
PHPBB3-15531
This commit is contained in:
@@ -385,7 +385,7 @@ class phpbb_test_case_helpers
|
||||
$mb = $this->test_case->getMockBuilder('phpbb\\textformatter\\data_access');
|
||||
$mb->setMethods(array('get_bbcodes', 'get_censored_words', 'get_smilies', 'get_styles'));
|
||||
$mb->setConstructorArgs(array(
|
||||
$this->test_case->getMock('phpbb\\db\\driver\\driver'),
|
||||
$this->test_case->getMockBuilder('phpbb\\db\\driver\\driver')->getMock(),
|
||||
'phpbb_bbcodes',
|
||||
'phpbb_smilies',
|
||||
'phpbb_styles',
|
||||
@@ -489,8 +489,11 @@ class phpbb_test_case_helpers
|
||||
$request = new phpbb_mock_request;
|
||||
}
|
||||
|
||||
// Get a log interface
|
||||
$log = ($container->has('log')) ? $container->get('log') : $this->test_case->getMockBuilder('phpbb\\log\\log_interface')->getMock();
|
||||
|
||||
// Create and register the text_formatter.s9e.factory service
|
||||
$factory = new \phpbb\textformatter\s9e\factory($dal, $cache, $dispatcher, $config, new \phpbb\textformatter\s9e\link_helper, $cache_dir, $cache_key_parser, $cache_key_renderer);
|
||||
$factory = new \phpbb\textformatter\s9e\factory($dal, $cache, $dispatcher, $config, new \phpbb\textformatter\s9e\link_helper, $log, $cache_dir, $cache_key_parser, $cache_key_renderer);
|
||||
$container->set('text_formatter.s9e.factory', $factory);
|
||||
|
||||
// Create a user if none was provided, and add the common lang strings
|
||||
|
@@ -56,6 +56,7 @@ class phpbb_textformatter_s9e_factory_test extends phpbb_database_test_case
|
||||
$this->dispatcher,
|
||||
new \phpbb\config\config(array('allowed_schemes_links' => 'http,https,ftp')),
|
||||
new \phpbb\textformatter\s9e\link_helper,
|
||||
$this->getMockBuilder('phpbb\\log\\log_interface')->getMock(),
|
||||
$this->get_cache_dir(),
|
||||
'_foo_parser',
|
||||
'_foo_renderer'
|
||||
@@ -263,6 +264,23 @@ class phpbb_textformatter_s9e_factory_test extends phpbb_database_test_case
|
||||
$this->assertSame($expected, $renderer->render($parser->parse($original)));
|
||||
}
|
||||
|
||||
/**
|
||||
* @testdox Logs malformed BBCodes
|
||||
*/
|
||||
public function test_malformed_bbcodes()
|
||||
{
|
||||
$log = $this->getMockBuilder('phpbb\\log\\log_interface')->getMock();
|
||||
$log->expects($this->once())
|
||||
->method('add')
|
||||
->with('critical', null, null, 'LOG_BBCODE_CONFIGURATION_ERROR', false, ['[x !x]{TEXT}[/x]', 'Cannot interpret the BBCode definition']);
|
||||
|
||||
$container = new phpbb_mock_container_builder;
|
||||
$container->set('log', $log);
|
||||
|
||||
$fixture = __DIR__ . '/fixtures/malformed_bbcode.xml';
|
||||
$this->get_test_case_helpers()->set_s9e_services($container, $fixture);
|
||||
}
|
||||
|
||||
/**
|
||||
* @testdox get_configurator() triggers events before and after configuration
|
||||
*/
|
||||
|
28
tests/text_formatter/s9e/fixtures/malformed_bbcode.xml
Normal file
28
tests/text_formatter/s9e/fixtures/malformed_bbcode.xml
Normal file
@@ -0,0 +1,28 @@
|
||||
<?xml version="1.0" encoding="UTF-8" ?>
|
||||
<dataset>
|
||||
<table name="phpbb_bbcodes">
|
||||
<column>bbcode_id</column>
|
||||
<column>bbcode_tag</column>
|
||||
<column>bbcode_helpline</column>
|
||||
<column>display_on_posting</column>
|
||||
<column>bbcode_match</column>
|
||||
<column>bbcode_tpl</column>
|
||||
<column>first_pass_match</column>
|
||||
<column>first_pass_replace</column>
|
||||
<column>second_pass_match</column>
|
||||
<column>second_pass_replace</column>
|
||||
|
||||
<row>
|
||||
<value>13</value>
|
||||
<value>x</value>
|
||||
<value></value>
|
||||
<value>1</value>
|
||||
<value>[x !x]{TEXT}[/x]</value>
|
||||
<value>...</value>
|
||||
<value/>
|
||||
<value/>
|
||||
<value/>
|
||||
<value/>
|
||||
</row>
|
||||
</table>
|
||||
</dataset>
|
Reference in New Issue
Block a user