mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 05:50:42 +02:00
Code Issues Releases Wiki Activity

[ticket/16649] Add compiler pass to tests

Browse Source 
PHPBB3-16649
This commit is contained in:
rubencm
2020-12-09 02:28:09 +01:00
committed by rxu
parent 302632d240
commit 538ff83ccc
5 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
phpBB/phpbb/di/container_builder.php
View File

@@ -198,9 +198,6 @@ class container_builder
$this->container = $this->create_container($this->container_extensions);
// Mark all services public
$this->container->addCompilerPass(new pass\markpublic_pass());
// Easy collections through tags
$this->container->addCompilerPass(new pass\collection_pass());
@@ -220,6 +217,9 @@ class container_builder
$this->inject_custom_parameters();
// Mark all services public
$this->container->addCompilerPass(new pass\markpublic_pass());
if ($this->compile_container)
{
$this->container->compile();

8
phpBB/phpbb/di/pass/markpublic_pass.php
View File

@@ -36,5 +36,13 @@ class markpublic_pass implements CompilerPassInterface
$definition->setPublic(true);
}
}
foreach ($container->getAliases() as $alias)
{
if ($alias->isPrivate())
{
$alias->setPublic(true);
}
}
}
}

3
tests/notification/base.php
View File

@@ -125,6 +125,9 @@ abstract class phpbb_tests_notification_base extends phpbb_database_test_case
);
$phpbb_container->set('notification_manager', $this->notifications);
$phpbb_container->addCompilerPass(new phpbb\di\pass\markpublic_pass());
$phpbb_container->compile();
$this->notifications->setDependencies($this->auth, $this->config);

3
tests/notification/notification_method_email_test.php
View File

@@ -129,6 +129,9 @@ class notification_method_email_test extends phpbb_tests_notification_base
);
$phpbb_container->set('notification_manager', $this->notifications);
$phpbb_container->addCompilerPass(new phpbb\di\pass\markpublic_pass());
$phpbb_container->compile();
$this->notifications->setDependencies($this->auth, $this->config);

1
tests/notification/submit_post_base.php
View File

@@ -137,6 +137,7 @@ abstract class phpbb_notification_submit_post_base extends phpbb_database_test_c
$phpbb_container->setParameter('tables.notification_types', 'phpbb_notification_types');
$phpbb_container->setParameter('tables.notification_emails', 'phpbb_notification_emails');
$phpbb_container->set('content.visibility', new \phpbb\content_visibility($auth, $config, $phpbb_dispatcher, $db, $user, $phpbb_root_path, $phpEx, FORUMS_TABLE, POSTS_TABLE, TOPICS_TABLE, USERS_TABLE));
$phpbb_container->addCompilerPass(new phpbb\di\pass\markpublic_pass());
$phpbb_container->compile();
// Notification Types