mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/16902] Make flood interval control in tests consistent

Browse Source 
Also remove crawler dumping tool

PHPBB3-16902
This commit is contained in:
rxu
2022-01-15 10:37:45 +07:00
parent f7a240f3fa
commit 54fd71ea2e
7 changed files with 9 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/test_framework/phpbb_functional_test_case.php
View File

@@ -983,7 +983,7 @@ class phpbb_functional_test_case extends phpbb_test_case
// Any output before the doc type means there was an error
$content = self::get_content();
self::assertStringNotContainsString('[phpBB Debug]', $content);
self::assertStringStartsWith('<!DOCTYPE', strtoupper(substr(trim($content), 0, 10)), 'Output found before DOCTYPE specification.');
self::assertStringStartsWith('<!DOCTYPE', strtoupper(substr(trim($content), 0, 10)), $content);
if ($status_code !== false)
{
@@ -1447,31 +1447,6 @@ class phpbb_functional_test_case extends phpbb_test_case
return $file_form_data;
}
/**
* Get HTML of the crawler
* See https://symfony.com/doc/current/components/dom_crawler.html#component-dom-crawler-dumping
*
* @param Symfony\Component\DomCrawler\Crawler $crawler Crawler instance
* @param string $url Request URL
*
* @return array Hidden form fields array
*/
protected function dump_crawler($crawler)
{
if (!$crawler)
{
return;
}
$html = '';
foreach ($crawler as $domElement)
{
$html .= $domElement->ownerDocument->saveHTML($domElement);
}
return $html;
}
/**
* Get username of currently logged in user
*
@@ -1490,9 +1465,9 @@ class phpbb_functional_test_case extends phpbb_test_case
}
/**
* Disable posting flood control
* Posting flood control
*/
protected function disable_flood_interval()
protected function set_flood_interval($flood_interval)
{
$relogin_back = false;
$logged_in_username = $this->get_logged_in_user();
@@ -1511,7 +1486,7 @@ class phpbb_functional_test_case extends phpbb_test_case
$this->add_lang('acp/common');
$crawler = self::request('GET', 'adm/index.php?i=acp_board&mode=post&sid=' . $this->sid);
$form = $crawler->selectButton('submit')->form([
'config[flood_interval]' => 0,
'config[flood_interval]' => $flood_interval,
]);
$crawler = self::submit($form);
$this->assertContainsLang('CONFIG_UPDATED', $crawler->text());