mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 14:00:31 +02:00
Code Issues Releases Wiki Activity

[ticket/14457] Replaces unique_id implementation by random_bytes()

Browse Source 
PHPBB3-14457
This commit is contained in:
Tristan Darricau
2016-02-17 22:10:09 +01:00
parent 08a11dbe32
commit 58359b1587
4 changed files with 60 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
phpBB/includes/functions.php
View File

@@ -93,25 +93,10 @@ function gen_rand_string_friendly($num_chars = 8)
/**
* Return unique id
* @param string $extra additional entropy
*/
function unique_id($extra = 'c')
function unique_id()
{
static $dss_seeded = false;
global $config;
$val = $config['rand_seed'] . microtime();
$val = md5($val);
$config['rand_seed'] = md5($config['rand_seed'] . $val . $extra);
if ($dss_seeded !== true && ($config['rand_seed_last_update'] < time() - rand(1,10)))
{
$config->set('rand_seed_last_update', time(), false);
$config->set('rand_seed', $config['rand_seed'], false);
$dss_seeded = true;
}
return substr($val, 4, 16);
return bin2hex(random_bytes(6));
}
/**