[feature/migrations] Migrations now somewhat works

PHPBB3-9737

phpBB/config/migrator.yml

@@ -0,0 +1,49 @@
+services:
+    migrator:
+        class: phpbb_db_migrator
+        arguments:
+            - @config
+            - @dbal.conn
+            - @dbal.tools
+            - %tables.migrations%
+            - %core.root_path%
+            - %core.php_ext%
+            - %core.table_prefix%
+            - @migrator.tool_collection
+
+    migrator.tool_collection:
+        class: phpbb_di_service_collection
+        arguments:
+            - @service_container
+        tags:
+            - { name: service_collection, tag: migrator.tool }
+
+    migrator.tool.config:
+        class: phpbb_db_migration_tool_config
+        arguments:
+            - @config
+        tags:
+            - { name: migrator.tool }
+
+    migrator.tool.module:
+        class: phpbb_db_migration_tool_module
+        arguments:
+            - @dbal.conn
+            - @cache
+            - @user
+            - %core.root_path%
+            - %core.php_ext%
+            - %tables.modules%
+        tags:
+            - { name: migrator.tool }
+
+    migrator.tool.permission:
+        class: phpbb_db_migration_tool_permission
+        arguments:
+            - @dbal.conn
+            - @cache
+            - @auth
+            - %core.root_path%
+            - %core.php_ext%
+        tags:
+            - { name: migrator.tool }

phpBB/config/services.yml

@@ -1,6 +1,7 @@
 imports:
     - { resource: tables.yml }
     - { resource: cron_tasks.yml }
+    - { resource: migrator.yml }
 
 services:
     auth:
@@ -162,45 +163,6 @@ services:
         tags:
             - { name: kernel.event_subscriber }
 
-    migrator:
-        class: phpbb_db_migrator
-        arguments:
-            - @service_container
-
-    migrator.tools_collection
-        class: phpbb_di_service_collection
-        arguments:
-            - @service_container
-
-    migrator.tools.config:
-        class: phpbb_db_migration_tools_config
-        arguments:
-            - @config
-        tags:
-            - { name: migrator:tool }
-
-    migrator.tools.module:
-        class: phpbb_db_migration_tools_module
-        arguments:
-            - @db
-            - @cache
-            - @user
-            - %core.root_path%
-            - %core.php_ext%
-        tags:
-            - { name: migrator:tool }
-
-    migrator.tools.permission:
-        class: phpbb_db_migration_tools_permission
-        arguments:
-            - @db
-            - @cache
-            - @auth
-            - %core.root_path%
-            - %core.php_ext%
-        tags:
-            - { name: migrator:tool }
-
     request:
         class: phpbb_request
 

phpBB/config/tables.yml

@@ -2,3 +2,4 @@ parameters:
     tables.config: %core.table_prefix%config
     tables.ext: %core.table_prefix%ext
     tables.migrations: %core.table_prefix%migrations
+    tables.modules: %core.table_prefix%modules