mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-07 17:27:16 +02:00
Code Issues Releases Wiki Activity

Merge remote-tracking branch 'igorw/ticket/9608' into develop

Browse Source 
* igorw/ticket/9608:
  [ticket/9608] Remove use of references in topic_review
  [ticket/9608] Revert changes to normalizer
  [ticket/9608] Remove blank line
  [ticket/9608] Remove use of references in captcha and other places
This commit is contained in:
Oleg Pudeyev
2011-08-14 19:24:27 -04:00
parent 5305f6a977 749ab6547d
commit 5fa096aca4
12 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
phpBB/includes/acp/acp_captcha.php
View File

@@ -46,7 +46,7 @@ class acp_captcha
// Delegate
if ($configure)
{
$config_captcha =& phpbb_captcha_factory::get_instance($selected);
$config_captcha = phpbb_captcha_factory::get_instance($selected);
$config_captcha->acp_page($id, $this);
}
else
@@ -78,11 +78,11 @@ class acp_captcha
// sanity check
if (isset($captchas['available'][$selected]))
{
$old_captcha =& phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$old_captcha = phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$old_captcha->uninstall();
set_config('captcha_plugin', $selected);
$new_captcha =& phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$new_captcha = phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$new_captcha->install();
add_log('admin', 'LOG_CONFIG_VISUAL');
@@ -113,7 +113,7 @@ class acp_captcha
$captcha_select .= '<option value="' . $value . '"' . $current . ' class="disabled-option">' . $user->lang[$title] . '</option>';
}
$demo_captcha =& phpbb_captcha_factory::get_instance($selected);
$demo_captcha = phpbb_captcha_factory::get_instance($selected);
foreach ($config_vars as $config_var => $options)
{
@@ -136,7 +136,7 @@ class acp_captcha
{
global $db, $user, $config;
$captcha =& phpbb_captcha_factory::get_instance($selected);
$captcha = phpbb_captcha_factory::get_instance($selected);
$captcha->init(CONFIRM_REG);
$captcha->execute_demo();

2
phpBB/includes/auth/auth_db.php
View File

@@ -129,7 +129,7 @@ function login_db($username, $password, $ip = '', $browser = '', $forwarded_for
include ($phpbb_root_path . 'includes/captcha/captcha_factory.' . $phpEx);
}
$captcha =& phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$captcha = phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$captcha->init(CONFIRM_LOGIN);
$vc_response = $captcha->validate($row);
if ($vc_response)

2
phpBB/includes/captcha/captcha_factory.php
View File

@@ -26,7 +26,7 @@ class phpbb_captcha_factory
/**
* return an instance of class $name in file $name_plugin.php
*/
function &get_instance($name)
function get_instance($name)
{
global $phpbb_root_path, $phpEx;

4
phpBB/includes/captcha/plugins/phpbb_captcha_gd_plugin.php
View File

@@ -50,9 +50,9 @@ class phpbb_captcha_gd extends phpbb_default_captcha
}
}
function &get_instance()
function get_instance()
{
$instance =& new phpbb_captcha_gd();
$instance = new phpbb_captcha_gd();
return $instance;
}

4
phpBB/includes/captcha/plugins/phpbb_captcha_nogd_plugin.php
View File

@@ -40,9 +40,9 @@ class phpbb_captcha_nogd extends phpbb_default_captcha
}
}
function &get_instance()
function get_instance()
{
$instance =& new phpbb_captcha_nogd();
$instance = new phpbb_captcha_nogd();
return $instance;
}

4
phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php
View File

@@ -99,9 +99,9 @@ class phpbb_captcha_qa
/**
* API function
*/
function &get_instance()
function get_instance()
{
$instance =& new phpbb_captcha_qa();
$instance = new phpbb_captcha_qa();
return $instance;
}

4
phpBB/includes/captcha/plugins/phpbb_recaptcha_plugin.php
View File

@@ -54,9 +54,9 @@ class phpbb_recaptcha extends phpbb_default_captcha
$this->response = request_var('recaptcha_response_field', '');
}
function &get_instance()
function get_instance()
{
$instance =& new phpbb_recaptcha();
$instance = new phpbb_recaptcha();
return $instance;
}

2
phpBB/includes/functions_posting.php
View File

@@ -1078,7 +1078,7 @@ function topic_review($topic_id, $forum_id, $mode = 'topic_review', $cur_post_id
continue;
}
$row =& $rowset[$post_list[$i]];
$row = $rowset[$post_list[$i]];
$poster_id = $row['user_id'];
$post_subject = $row['post_subject'];

7
phpBB/includes/ucp/ucp_register.php
View File

@@ -156,13 +156,12 @@ class ucp_register
$this->tpl_name = 'ucp_agreement';
return;
}
// The CAPTCHA kicks in here. We can't help that the information gets lost on language change.
// The CAPTCHA kicks in here. We can't help that the information gets lost on language change.
if ($config['enable_confirm'])
{
include($phpbb_root_path . 'includes/captcha/captcha_factory.' . $phpEx);
$captcha =& phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$captcha = phpbb_captcha_factory::get_instance($config['captcha_plugin']);
$captcha->init(CONFIRM_REG);
}