mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-02 23:07:39 +02:00
Code Issues Releases Wiki Activity

[ticket/11008] Change onunload_functions to not use eval()

Browse Source 
PHPBB3-11008
This commit is contained in:
Igor Wiedler
2012-07-20 23:59:04 +02:00
parent ca43a8947a
commit 61f7f1b8ed
6 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpBB/styles/prosilver/template/login_body.html
View File

@@ -2,7 +2,9 @@
<script type="text/javascript"> <script type="text/javascript">
// <![CDATA[ // <![CDATA[
onload_functions.push('document.getElementById("<!-- IF S_ADMIN_AUTH -->{PASSWORD_CREDENTIAL}<!-- ELSE -->{USERNAME_CREDENTIAL}<!-- ENDIF -->").focus();'); onload_functions.push(function () {
document.getElementById("<!-- IF S_ADMIN_AUTH -->{PASSWORD_CREDENTIAL}<!-- ELSE -->{USERNAME_CREDENTIAL}<!-- ENDIF -->").focus();
});
// ]]> // ]]>
</script> </script>

4
phpBB/styles/prosilver/template/overall_header.html
View File

@@ -56,7 +56,7 @@
{ {
for (var i = 0; i < onload_functions.length; i++) for (var i = 0; i < onload_functions.length; i++)
{ {
eval(onload_functions[i]); onload_functions[i]();
} }
}; };
@@ -64,7 +64,7 @@
{ {
for (var i = 0; i < onunload_functions.length; i++) for (var i = 0; i < onunload_functions.length; i++)
{ {
eval(onunload_functions[i]); onunload_functions[i]();
} }
}; };

2
phpBB/styles/prosilver/template/posting_editor.html
View File

@@ -1,6 +1,6 @@
<script type="text/javascript"> <script type="text/javascript">
// <![CDATA[ // <![CDATA[
onload_functions.push('apply_onkeypress_event()'); onload_functions.push(apply_onkeypress_event);
// ]]> // ]]>
</script> </script>

4
phpBB/styles/prosilver/template/search_body.html
View File

@@ -2,7 +2,9 @@
<script type="text/javascript"> <script type="text/javascript">
// <![CDATA[ // <![CDATA[
onload_functions.push('document.getElementById("keywords").focus();'); onload_functions.push(function () {
document.getElementById("keywords").focus();
});
// ]]> // ]]>
</script> </script>

4
phpBB/styles/prosilver/template/simple_header.html
View File

@@ -26,7 +26,7 @@
{ {
for (var i = 0; i < onload_functions.length; i++) for (var i = 0; i < onload_functions.length; i++)
{ {
eval(onload_functions[i]); onload_functions[i]();
} }
} }
@@ -34,7 +34,7 @@
{ {
for (var i = 0; i < onunload_functions.length; i++) for (var i = 0; i < onunload_functions.length; i++)
{ {
eval(onunload_functions[i]); onunload_functions[i]();
} }
} }

2
phpBB/styles/prosilver/template/ucp_register.html
View File

@@ -12,7 +12,7 @@
} }
<!-- IF CAPTCHA_TEMPLATE and S_CONFIRM_REFRESH --> <!-- IF CAPTCHA_TEMPLATE and S_CONFIRM_REFRESH -->
onload_functions.push('apply_onkeypress_event()'); onload_functions.push(apply_onkeypress_event);
<!-- ENDIF --> <!-- ENDIF -->
// ]]> // ]]>