mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-14 12:44:06 +02:00
Code Issues Releases Wiki Activity

[ticket/16549] Remove exception expectation annotations

Browse Source 
PHPBB3-16549
This commit is contained in:
rxu
2020-07-13 14:20:55 +07:00
parent fb62d22013
commit 632bcdd2da
10 changed files with 27 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/console/cron/run_test.php
View File

@@ -109,12 +109,11 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertSame(false, $this->lock->owns_lock());
}
/**
* @expectedException \phpbb\exception\runtime_exception
* @expectedExceptionMessage CRON_LOCK_ERROR
*/
public function test_error_lock()
{
$this->expectException(\phpbb\exception\runtime_exception::class);
$this->expectException('CRON_LOCK_ERROR');
$this->lock->acquire();
$command_tester = $this->get_command_tester();
$exit_status = $command_tester->execute(array('command' => $this->command_name));
@@ -231,12 +230,11 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertSame(false, $this->lock->owns_lock());
}
/**
* @expectedException \phpbb\exception\runtime_exception
* @expectedExceptionMessage CRON_NO_SUCH_TASK
*/
public function test_arg_invalid()
{
$this->expectException(\phpbb\exception\runtime_exception::class);
$this->expectException('CRON_NO_SUCH_TASK');
$command_tester = $this->get_command_tester();
$exit_status = $command_tester->execute(array('command' => $this->command_name, 'name' => 'foo'));

5
tests/console/update/check_test.php
View File

@@ -65,11 +65,10 @@ class phpbb_console_command_check_test extends phpbb_test_case
$this->assertSame($status, 1);
}
/**
* @expectedException phpbb\exception\runtime_exception
*/
public function test_error()
{
$this->expectException(\phpbb\exception\runtime_exception::class);
$command_tester = $this->get_command_tester('1');
$this->version_helper->set_file_location('acme.corp','foo', 'bar.json');