mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 22:10:45 +02:00
Code Issues Releases Wiki Activity

[ticket/17281] Update psalm config and fix issues

Browse Source 
PHPBB3-17281
This commit is contained in:
Marc Alexander
2023-12-30 17:41:12 +01:00
parent c6c299eea4
commit 661a8a6117
42 changed files with 107 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpBB/phpbb/db/doctrine/type_converter.php
View File

@@ -74,7 +74,7 @@ class type_converter
* @param string $type Legacy type name.
* @param int $length Type length.
*
* @return array{string, array} Pair of type name and options.
* @return array{string, array{string, ...}} Pair of type name and options.
*/
private static function mapWithLength(string $type, int $length): array
{

2
phpBB/phpbb/db/driver/mssql_odbc.php
View File

@@ -279,7 +279,7 @@ class mssql_odbc extends \phpbb\db\driver\mssql_base
{
$id = odbc_result($result_id, 1);
odbc_free_result($result_id);
return $id;
return $id ? (int) $id : false;
}
odbc_free_result($result_id);
}

2
phpBB/phpbb/db/migration/exception.php
View File

@@ -44,7 +44,7 @@ class exception extends \Exception
*
* @return string
*/
public function __toString()
public function __toString(): string
{
return $this->message . ': ' . var_export($this->parameters, true);
}

1
phpBB/phpbb/db/migration/tool/module.php
View File

@@ -103,6 +103,7 @@ class module implements \phpbb\db\migration\tool\tool_interface
foreach ($parent_sqls as $parent_sql)
{
/** @psalm-suppress NoValue */
$sql = 'SELECT module_id
FROM ' . $this->modules_table . "
WHERE module_class = '" . $this->db->sql_escape($class) . "'