From 6cd54639b5e3e36fa13c09e5c9910c836230ccb6 Mon Sep 17 00:00:00 2001 From: rxu Date: Fri, 14 Aug 2020 04:30:20 +0700 Subject: [PATCH] [ticket/16526] Adjust test to use better assertions PHPBB3-16526 --- tests/functional/acp_post_settings_test.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/acp_post_settings_test.php b/tests/functional/acp_post_settings_test.php index 3c279e8129..6d03d4c853 100644 --- a/tests/functional/acp_post_settings_test.php +++ b/tests/functional/acp_post_settings_test.php @@ -31,7 +31,7 @@ class phpbb_functional_acp_post_settings_test extends phpbb_functional_test_case ]); $crawler = self::submit($form); $this->assertContainsLang('WARNING', $crawler->filter('div[class="errorbox"] > h3')->text()); - $this->assertContains($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text()); + $this->assertStringContainsString($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text()); // Test trailing comma and invalid scheme - invalid $form = $crawler->selectButton($this->lang('SUBMIT'))->form([ @@ -39,8 +39,8 @@ class phpbb_functional_acp_post_settings_test extends phpbb_functional_test_case ]); $crawler = self::submit($form); $this->assertContainsLang('WARNING', $crawler->filter('div[class="errorbox"] > h3')->text()); - $this->assertContains($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text()); - $this->assertContains($this->lang('URL_SCHEME_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS'), '2ftp'), $crawler->filter('div[class="errorbox"] > p')->text()); + $this->assertStringContainsString($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text()); + $this->assertStringContainsString($this->lang('URL_SCHEME_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS'), '2ftp'), $crawler->filter('div[class="errorbox"] > p')->text()); // Test empty setting - valid $form = $crawler->selectButton($this->lang('SUBMIT'))->form([