[ticket/12597] Update pull-request

Removes a useless comment.
Switchs command name from cron:execute-all to cron:run-all.
Replaces assertEquals by assertSame

PHPBB3-12597

phpBB/config/console.yml

@@ -46,8 +46,8 @@ services:
         tags:
             - { name: console.command }
 
-    console.command.cron.execute_all:
-        class: phpbb\console\command\cron\execute_all
+    console.command.cron.run_all:
+        class: phpbb\console\command\cron\run_all
         arguments:
             - @cron.manager
             - @cron.lock_db

phpBB/cron.php

@@ -50,7 +50,6 @@ if ($cron_lock->acquire())
 {
 	$cron = $phpbb_container->get('cron.manager');
 
-	// If invalid task is specified, empty $run_tasks is passed to do_cron which then does nothing
 	$task = $cron->find_task($cron_type);
 	if ($task)
 	{

phpBB/phpbb/console/command/cron/run_all.php

@@ -12,7 +12,7 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
-class execute_all extends \phpbb\console\command\command
+class run_all extends \phpbb\console\command\command
 {
 	/** @var \phpbb\cron\manager */
 	protected $cron_manager;
@@ -47,7 +47,7 @@ class execute_all extends \phpbb\console\command\command
 	protected function configure()
 	{
 		$this
-			->setName('cron:execute-all')
+			->setName('cron:run-all')
 			->setDescription($this->user->lang('CLI_DESCR_CRON_EXECUTE_ALL'))
 		;
 	}