mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 05:50:42 +02:00
Code Issues Releases Wiki Activity

[ticket/9823] Unit tests for validate_config_vars.

Browse Source 
Fix some documentations and use the $max-var instead of the magic-number
in validate_config_vars.

PHPBB3-9823
This commit is contained in:
Joas Schilling
2010-09-16 13:04:12 +02:00
parent 11e3804f97
commit 737849bc23
4 changed files with 159 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpBB/includes/functions_acp.php
View File

@@ -300,7 +300,7 @@ function build_cfg_template($tpl_type, $key, &$new, $config_key, $vars)
}
/**
* Going through a config array and validate values, writing errors to $error. The validation method accepts parameters separated by ':' for string and int.
* Going through a config array and validate values, writing errors to $error. The validation method accepts parameters separated by ':' for string and int.
* The first parameter defines the type to be used, the second the lower bound and the third the upper bound. Only the type is required.
*/
function validate_config_vars($config_vars, &$cfg_array, &$error)
@@ -337,7 +337,7 @@ function validate_config_vars($config_vars, &$cfg_array, &$error)
{
$error[] = sprintf($user->lang['SETTING_TOO_SHORT'], $user->lang[$config_definition['lang']], $validator[$min]);
}
else if (isset($validator[$max]) && $length > $validator[2])
else if (isset($validator[$max]) && $length > $validator[$max])
{
$error[] = sprintf($user->lang['SETTING_TOO_LONG'], $user->lang[$config_definition['lang']], $validator[$max]);
}