mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-23 08:43:02 +02:00
Code Issues Releases Wiki Activity

[ticket/13454] Remove unused variables

Browse Source 
This is the first part of the changes. More to come.

PHPBB3-13454
This commit is contained in:
Marc Alexander
2015-12-03 17:50:29 +01:00
parent d0adbe94d5
commit 73e6e5b77f
72 changed files with 85 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpBB/includes/mcp/mcp_front.php
View File

@@ -24,7 +24,7 @@ if (!defined('IN_PHPBB'))
*/
function mcp_front_view($id, $mode, $action)
{
global $phpEx, $phpbb_root_path, $config;
global $phpEx, $phpbb_root_path;
global $template, $db, $user, $auth, $module;
global $phpbb_dispatcher, $request;

2
phpBB/includes/mcp/mcp_logs.php
View File

@@ -36,7 +36,7 @@ class mcp_logs
function main($id, $mode)
{
global $auth, $db, $user, $template, $request;
global $config, $phpbb_root_path, $phpEx, $phpbb_container, $phpbb_log;
global $config, $phpbb_container, $phpbb_log;
$user->add_lang('acp/common');

4
phpBB/includes/mcp/mcp_main.php
View File

@@ -35,8 +35,8 @@ class mcp_main
function main($id, $mode)
{
global $auth, $db, $user, $template, $action;
global $config, $phpbb_root_path, $phpEx, $request;
global $auth, $user, $action;
global $phpbb_root_path, $phpEx, $request;
global $phpbb_dispatcher;
$quickmod = ($mode == 'quickmod') ? true : false;

6
phpBB/includes/mcp/mcp_notes.php
View File

@@ -35,8 +35,8 @@ class mcp_notes
function main($id, $mode)
{
global $auth, $db, $user, $template, $request;
global $config, $phpbb_root_path, $phpEx;
global $user, $template, $request;
global $phpbb_root_path, $phpEx;
$action = $request->variable('action', array('' => ''));
@@ -74,7 +74,7 @@ class mcp_notes
*/
function mcp_notes_user_view($action)
{
global $phpEx, $phpbb_root_path, $config, $phpbb_log, $request;
global $config, $phpbb_log, $request;
global $template, $db, $user, $auth, $phpbb_container;
$user_id = $request->variable('u', 0);

2
phpBB/includes/mcp/mcp_pm_reports.php
View File

@@ -35,7 +35,7 @@ class mcp_pm_reports
function main($id, $mode)
{
global $auth, $db, $user, $template, $cache, $request;
global $auth, $db, $user, $template, $request;
global $config, $phpbb_root_path, $phpEx, $action, $phpbb_container;
include_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx);

3
phpBB/includes/mcp/mcp_post.php
View File

@@ -128,7 +128,6 @@ function mcp_post_details($id, $mode, $action)
$users_ary = $usernames_ary = array();
$attachments = $extensions = array();
$post_id = $post_info['post_id'];
$topic_tracking_info = array();
// Get topic tracking info
if ($config['load_db_lastread'])
@@ -150,8 +149,6 @@ function mcp_post_details($id, $mode, $action)
if ($post_info['post_attachment'] && $auth->acl_get('u_download') && $auth->acl_get('f_download', $post_info['forum_id']))
{
$extensions = $cache->obtain_attach_extensions($post_info['forum_id']);
$sql = 'SELECT *
FROM ' . ATTACHMENTS_TABLE . '
WHERE post_msg_id = ' . $post_id . '

2
phpBB/includes/mcp/mcp_reports.php
View File

@@ -35,7 +35,7 @@ class mcp_reports
function main($id, $mode)
{
global $auth, $db, $user, $template, $cache, $request;
global $auth, $db, $user, $template, $request;
global $config, $phpbb_root_path, $phpEx, $action, $phpbb_container, $phpbb_dispatcher;
include_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx);

2
phpBB/includes/mcp/mcp_topic.php
View File

@@ -156,8 +156,6 @@ function mcp_topic_view($id, $mode, $action)
}
$db->sql_freeresult($result);
$topic_tracking_info = array();
// Get topic tracking info
if ($config['load_db_lastread'])
{

9
phpBB/includes/mcp/mcp_warn.php
View File

@@ -35,8 +35,7 @@ class mcp_warn
function main($id, $mode)
{
global $auth, $db, $user, $template, $request;
global $config, $phpbb_root_path, $phpEx;
global $request;
$action = $request->variable('action', array('' => ''));
@@ -78,8 +77,8 @@ class mcp_warn
*/
function mcp_warn_front_view()
{
global $phpEx, $phpbb_root_path, $config;
global $template, $db, $user, $auth;
global $phpEx, $phpbb_root_path;
global $template, $db, $user;
$template->assign_vars(array(
'U_FIND_USERNAME' => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=searchuser&form=mcp&field=username&select_single=true'),
@@ -132,7 +131,7 @@ class mcp_warn
function mcp_warn_list_view($action)
{
global $phpEx, $phpbb_root_path, $config, $phpbb_container;
global $template, $db, $user, $auth, $request;
global $template, $user, $auth, $request;
/* @var $pagination \phpbb\pagination */
$pagination = $phpbb_container->get('pagination');