mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-24 20:17:58 +02:00
Code Issues Releases Wiki Activity

Merge pull request from 3D-I/ticket/16394

Browse Source 
[ticket/16394] Fix access array offset in MCP topic approval - PHP 7.4
This commit is contained in:
Marc Alexander
2020-03-15 15:38:12 +01:00
parent b732b4d8c8 5dac5fdb3b
commit 7557af0594
1 changed files with 7 additions and 7 deletions

14
phpBB/mcp.php

@ -82,25 +82,25 @@ if ($post_id)
{
// We determine the topic and forum id here, to make sure the moderator really has moderative rights on this post
$sql = 'SELECT topic_id, forum_id
FROM ' . POSTS_TABLE . "
WHERE post_id = $post_id";
FROM ' . POSTS_TABLE . '
WHERE post_id = ' . (int) $post_id;
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$topic_id = (int) $row['topic_id'];
$forum_id = (int) $row['forum_id'];
$topic_id = $row['topic_id'] ?? false;
$forum_id = $row['forum_id'] ?? false;
}
else if ($topic_id)
{
$sql = 'SELECT forum_id
FROM ' . TOPICS_TABLE . "
WHERE topic_id = $topic_id";
FROM ' . TOPICS_TABLE . '
WHERE topic_id = ' . (int) $topic_id;
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$forum_id = (int) $row['forum_id'];
$forum_id = $row['forum_id'] ?? false;
}
// If the user doesn't have any moderator powers (globally or locally) he can't access the mcp