From b9123cad7cb1792f628057a9ede48c031f8397c0 Mon Sep 17 00:00:00 2001
From: 3D-I <480857+3D-I@users.noreply.github.com>
Date: Thu, 26 Mar 2020 00:56:45 +0100
Subject: [PATCH 1/2] [ticket/16416] Fix non-numeric value encountered - ACP
 attachments settings

PHPBB3-16416
---
 phpBB/includes/acp/acp_attachments.php | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/phpBB/includes/acp/acp_attachments.php b/phpBB/includes/acp/acp_attachments.php
index 0961223002..fd71845660 100644
--- a/phpBB/includes/acp/acp_attachments.php
+++ b/phpBB/includes/acp/acp_attachments.php
@@ -225,7 +225,15 @@ class acp_attachments
 					if (in_array($config_name, array('attachment_quota', 'max_filesize', 'max_filesize_pm')))
 					{
 						$size_var = $request->variable($config_name, '');
-						$this->new_config[$config_name] = $config_value = ($size_var == 'kb') ? round($config_value * 1024) : (($size_var == 'mb') ? round($config_value * 1048576) : $config_value);
+
+						if (!empty($config_value))
+						{
+							$this->new_config[$config_name] = $config_value = ($size_var == 'kb') ? round($config_value * 1024) : (($size_var == 'mb') ? round($config_value * 1048576) : $config_value);
+						}
+						else
+						{
+							$config_value = 0;
+						}
 					}
 
 					if ($submit)

From 5b5a29849e2e00c36e2d7b2b5651eb309bd8c4bf Mon Sep 17 00:00:00 2001
From: 3D-I <480857+3D-I@users.noreply.github.com>
Date: Thu, 26 Mar 2020 11:27:26 +0100
Subject: [PATCH 2/2] [ticket/16416] Fix non-numeric value encountered - ACP
 attachments settings

PHPBB3-16416
---
 phpBB/includes/acp/acp_attachments.php | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/phpBB/includes/acp/acp_attachments.php b/phpBB/includes/acp/acp_attachments.php
index fd71845660..f757186fac 100644
--- a/phpBB/includes/acp/acp_attachments.php
+++ b/phpBB/includes/acp/acp_attachments.php
@@ -226,14 +226,9 @@ class acp_attachments
 					{
 						$size_var = $request->variable($config_name, '');
 
-						if (!empty($config_value))
-						{
-							$this->new_config[$config_name] = $config_value = ($size_var == 'kb') ? round($config_value * 1024) : (($size_var == 'mb') ? round($config_value * 1048576) : $config_value);
-						}
-						else
-						{
-							$config_value = 0;
-						}
+						$config_value = (int) $config_value;
+
+						$this->new_config[$config_name] = $config_value = ($size_var == 'kb') ? round($config_value * 1024) : (($size_var == 'mb') ? round($config_value * 1048576) : $config_value);
 					}
 
 					if ($submit)