mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-09 02:06:32 +02:00
Code Issues Releases Wiki Activity

[ticket/17010] Move get subscription map to separate function and extend tests

Browse Source 
Unit tests will also now ensure there are no special surprises with more than
one subscription for users.

PHPBB3-17010
This commit is contained in:
Marc Alexander
2023-06-26 08:53:26 +02:00
parent b779ce5910
commit 79ff21fdf5
2 changed files with 36 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/notification/notification_method_webpush_test.php
View File

@@ -338,7 +338,14 @@ class notification_method_webpush_test extends phpbb_tests_notification_base
$subscription_info = [];
foreach ($expected_users as $user_id => $user_data)
{
$subscription_info[$user_id] = $this->create_subscription_for_user($user_id);
$subscription_info[$user_id][] = $this->create_subscription_for_user($user_id);
}
// Create second subscription for first user ID passed
if (count($expected_users))
{
$first_user_id = array_key_first($expected_users);
$subscription_info[$first_user_id][] = $this->create_subscription_for_user($first_user_id);
}
$post_data = array_merge([
@@ -361,7 +368,7 @@ class notification_method_webpush_test extends phpbb_tests_notification_base
foreach ($expected_users as $user_id => $data)
{
$messages = $this->get_messages_for_subscription($subscription_info[$user_id]['clientHash']);
$messages = $this->get_messages_for_subscription($subscription_info[$user_id][0]['clientHash']);
$this->assertEmpty($messages);
}
@@ -372,7 +379,7 @@ class notification_method_webpush_test extends phpbb_tests_notification_base
foreach ($expected_users as $user_id => $data)
{
$messages = $this->get_messages_for_subscription($subscription_info[$user_id]['clientHash']);
$messages = $this->get_messages_for_subscription($subscription_info[$user_id][0]['clientHash']);
$this->assertNotEmpty($messages);
}
}