1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00

[ticket/10369] Always include errfile and errline in format_errors().

We remove the phpBB root path from errfile. This is consistent with how
msg_handler handles E_WARNING messages etc.

PHPBB3-10369
This commit is contained in:
Andreas Fischer
2011-09-18 00:55:24 +02:00
parent eb8b1c333f
commit 7b3f6cb219
2 changed files with 44 additions and 5 deletions

View File

@@ -42,6 +42,8 @@ class phpbb_error_collector
function format_errors()
{
$phpbb_root_path = phpbb_realpath(dirname(__FILE__) . '/../');
$text = '';
foreach ($this->errors as $error)
{
@@ -49,13 +51,15 @@ class phpbb_error_collector
{
$text .= "<br />\n";
}
list($errno, $msg_text, $errfile, $errline) = $error;
$text .= "Errno $errno: $msg_text";
if (defined('DEBUG_EXTRA') || defined('IN_INSTALL'))
{
$text .= " at $errfile line $errline";
}
// Prevent leakage of local path to phpBB install
$errfile = str_replace(array($phpbb_root_path, '\\'), array('', '/'), $errfile);
$text .= "Errno $errno: $msg_text at $errfile line $errline";
}
return $text;
}
}