[feature/passwords] Get rid of unneeded code complexity

Simplified a little bit of code as pointed out by imkingdavid on github.

PHPBB3-11610

phpBB/phpbb/passwords/driver/bcrypt.php

@@ -29,9 +29,8 @@ class bcrypt extends base
 	*/
 	public function hash($password, $salt = '')
 	{
-		// The 2x and 2y prefixes of bcrypt might not be supported
-		// Revert to 2a if this is the case
-		$prefix = (!$this->is_supported()) ? '$2a$' : $this->get_prefix();
+		// Get prefix of this driver
+		$prefix = $this->get_prefix();
 
 		// Do not support 8-bit characters with $2a$ bcrypt
 		// Also see http://www.php.net/security/crypt_blowfish.php

phpBB/phpbb/passwords/driver/salted_md5.php

@@ -57,7 +57,7 @@ class salted_md5 extends base
 	*/
 	public function hash($password, $setting = '')
 	{
-		if ($setting != '')
+		if ($setting)
 		{
 			if (($settings = $this->get_hash_settings($setting)) === false)
 			{
@@ -95,14 +95,10 @@ class salted_md5 extends base
 	{
 		if (strlen($hash) !== 34)
 		{
-			return (md5($password) === $hash) ? true : false;
+			return md5($password) === $hash;
 		}
 
-		if ($hash === $this->hash($password, $hash))
-		{
-			return true;
-		}
-		return false;
+		return $hash === $this->hash($password, $hash);
 	}
 
 	/**

phpBB/phpbb/passwords/helper.php

@@ -26,10 +26,7 @@ class helper
 	*/
 	public function set_manager(\phpbb\passwords\manager $manager)
 	{
-		if ($this->manager === null)
-		{
-			$this->manager = $manager;
-		}
+		$this->manager = $manager;
 	}
 
 	/**