mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-29 21:10:31 +02:00
Code Issues Releases Wiki Activity

[feature/editor-code-tabs] Check for browser support in function

Browse Source 
Check for browser support and valid textarea in function instead of
before applying function.

PHPBB3-11557
This commit is contained in:
Vjacheslav Trushkin
2013-05-20 20:33:51 +03:00
parent b2e5cc8934
commit 809c51f30d
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpBB/assets/javascript/core.js
View File

@@ -681,6 +681,10 @@ phpbb.applyCodeEditor = function(textarea) {
startTagsEnd = ']', startTagsEnd = ']',
endTags = ['[/code]']; endTags = ['[/code]'];
if (!textarea || typeof textarea.selectionStart !== 'number') {
return;
}
if ($(textarea).data('code-editor') === true) { if ($(textarea).data('code-editor') === true) {
return; return;
} }

3
phpBB/styles/prosilver/template/editor.js
View File

@@ -415,9 +415,6 @@ function getCaretPosition(txtarea) {
} }
textarea = doc.forms[form_name].elements[text_name]; textarea = doc.forms[form_name].elements[text_name];
if (!textarea || typeof textarea.selectionStart !== 'number') {
return;
}
phpbb.applyCodeEditor(textarea); phpbb.applyCodeEditor(textarea);
}); });