my turn to break things... harharhar

- checking in permission settings and permission masks
- permission presets and documentation not finished yet
- added backtrace function to determine file/line for sql errors
- fixed marlist for orphan attachments/groups/logs/users
- able to change anonymous user settings/permissions now
- re-arranged admin permissions a bit (added some and removed some)
- setting forum permissions after creating/editing forum now selects every default group (copy permisson/dropdown to be added for adding forums)
- finished user permissions in users acp

note: the layout for permissions might change
devs: please empty the user_permissions in phpbb_users. Also, first change your auth_options table, remove all cache files and then re-set admin permissions. After having set the admin permissions you can update your modules table (else you will not see the permission tabs) - or empty the auth setting within the modules table to be able to see the permission modules (they rely on newly added permission options)


git-svn-id: file:///svn/phpbb/trunk@5553 89ea8834-ac86-4346-8a33-228a782c2dd0

phpBB/includes/functions_user.php

@@ -923,15 +923,16 @@ function validate_email($email)
 		return 'EMAIL_INVALID';
 	}
 
-	$banned = false;
-
-	// TODO: This is a duplication of code from session->check_ban()
+	/**
+	* @todo This is a duplication of code from session->check_ban()
+	*/
 	$sql = 'SELECT ban_ip, ban_userid, ban_email, ban_exclude, ban_give_reason, ban_end
 		FROM ' . BANLIST_TABLE . '
 		WHERE ban_end >= ' . time() . '
 			OR ban_end = 0';
 	$result = $db->sql_query($sql);
 
+	$banned = false;
 	if ($row = $db->sql_fetchrow($result))
 	{
 		do