mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/17347] Add tests for delete ids

Browse Source 
PHPBB-17347
This commit is contained in:
Marc Alexander
2024-06-20 22:23:38 +02:00
parent 77d1010081
commit 8432e506c4
3 changed files with 95 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpBB/language/en/cli.php
View File

@@ -159,7 +159,7 @@ $lang = array_merge($lang, array(
'CLI_USER_DELETE_CONFIRM' => 'Are you sure you want to delete ‘%s’? [y/N]',
'CLI_USER_DELETE_IDS_CONFIRM' => 'Are you sure you want to delete the user IDs ‘%s’? [y/N]',
'CLI_USER_DELETE_IDS_SUCCESS' => 'Successfully deleted user IDs.',
'CLI_USER_DELETE_IDS_NOT_FOUND' => 'No users were deleted by user ID.',
'CLI_USER_DELETE_NONE' => 'No users were deleted by user ID.',
'CLI_USER_RECLEAN_START' => 'Re-cleaning usernames',
'CLI_USER_RECLEAN_DONE' => [
0 => 'Re-cleaning complete. No usernames needed to be cleaned.',

20
phpBB/phpbb/console/command/user/delete_ids.php
View File

@@ -14,7 +14,6 @@
namespace phpbb\console\command\user;
use phpbb\console\command\command;
use phpbb\db\driver\driver_interface;
use phpbb\language\language;
use phpbb\log\log_interface;
use phpbb\user;
@@ -28,9 +27,6 @@ use Symfony\Component\Console\Style\SymfonyStyle;
class delete_ids extends command
{
/** @var driver_interface */
protected $db;
/** @var language */
protected $language;
@@ -40,18 +36,10 @@ class delete_ids extends command
/** @var user_loader */
protected $user_loader;
/**
* phpBB root path
*
* @var string
*/
/** @var string phpBB root path */
protected $phpbb_root_path;
/**
* PHP extension.
*
* @var string
*/
/** @var string PHP extension */
protected $php_ext;
/**
@@ -122,7 +110,7 @@ class delete_ids extends command
{
foreach ($user_ids as $user_id)
{
$user_row = $this->user_loader->get_user((int) $user_id);
$user_row = $this->user_loader->get_user($user_id);
// Skip anonymous user
if ($user_row['user_id'] == ANONYMOUS)
@@ -148,7 +136,7 @@ class delete_ids extends command
if (!$deleted_users)
{
$io->caution($this->language->lang('CLI_USER_DELETE_IDS_NOT_FOUND'));
$io->note($this->language->lang('CLI_USER_DELETE_NONE'));
}
return 0;