[ticket/14717] Quote strings beginning with @ or % in yaml definitions

This type of use was deprecated in symfony 2.8 and will be dropped in 3.x.
Also see: https://github.com/symfony/symfony/pull/16285

PHPBB3-14717

phpBB/config/default/container/services_auth.yml

@@ -103,7 +103,7 @@ services:
     auth.provider.oauth.service.twitter:
         class: phpbb\auth\provider\oauth\service\twitter
         arguments:
-            - @config
+            - '@config'
-            - @request
+            - '@request'
         tags:
             - { name: auth.provider.oauth.service }

tests/di/fixtures/config/production/container/environment.yml

@@ -8,7 +8,7 @@ services:
     dbal.conn:
         class: phpbb\db\driver\factory
         arguments:
-            - @service_container
+            - '@service_container'
 
     dispatcher:
         class: phpbb\db\driver\container_mock

tests/di/fixtures/config/test/container/environment.yml

@@ -8,7 +8,7 @@ services:
     dbal.conn:
         class: phpbb\db\driver\factory
         arguments:
-            - @service_container
+            - '@service_container'
 
     dispatcher:
         class: phpbb\db\driver\container_mock

tests/di/fixtures/other_config/production/container/environment.yml

@@ -8,7 +8,7 @@ services:
     dbal.conn:
         class: phpbb\db\driver\factory
         arguments:
-            - @service_container
+            - '@service_container'
 
     dispatcher:
         class: phpbb\db\driver\container_mock

tests/di/fixtures/other_config/test/container/environment.yml

@@ -8,7 +8,7 @@ services:
     dbal.conn:
         class: phpbb\db\driver\factory
         arguments:
-            - @service_container
+            - '@service_container'
 
     dispatcher:
         class: phpbb\db\driver\container_mock

tests/functional/fixtures/ext/foo/bar/config/services.yml

@@ -2,13 +2,13 @@ services:
     foo_bar.controller:
         class: foo\bar\controller\controller
         arguments:
-            - @controller.helper
+            - '@controller.helper'
-            - @path_helper
+            - '@path_helper'
-            - @template
+            - '@template'
-            - @config
+            - '@config'
-            - @user
+            - '@user'
-            - %core.root_path%
+            - '%core.root_path%'
-            - %core.php_ext%
+            - '%core.php_ext%'
 
     foo_bar.listener.permission:
         class: foo\bar\event\permission