mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-02 14:57:37 +02:00
Code Issues Releases Wiki Activity

[ticket/11015] Move comment in the right place.

Browse Source 
PHPBB3-11015
This commit is contained in:
Oleg Pudeyev
2012-12-13 19:21:23 -05:00
parent ee7dc9e5a0
commit 89f069637c
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
phpBB/includes/functions.php
View File

@@ -5573,6 +5573,13 @@ function phpbb_convert_30_dbms_to_31($dbms)
if (class_exists($dbms)) if (class_exists($dbms))
{ {
// Additionally we could check that $dbms extends phpbb_db_driver.
// http://php.net/manual/en/class.reflectionclass.php
// Beware of possible performance issues:
// http://stackoverflow.com/questions/294582/php-5-reflection-api-performance
// We could check for interface implementation in all paths or
// only when we do not prepend phpbb_db_driver_.
/* /*
$reflection = new \ReflectionClass($dbms); $reflection = new \ReflectionClass($dbms);
@@ -5585,13 +5592,6 @@ function phpbb_convert_30_dbms_to_31($dbms)
return $dbms; return $dbms;
} }
// Additionally we could check that $dbms extends phpbb_db_driver.
// http://php.net/manual/en/class.reflectionclass.php
// Beware of possible performance issues:
// http://stackoverflow.com/questions/294582/php-5-reflection-api-performance
// We could check for interface implementation in all paths or
// only when we do not prepend phpbb_db_driver_.
throw new \RuntimeException("You have specified an invalid dbms driver: $dbms"); throw new \RuntimeException("You have specified an invalid dbms driver: $dbms");
} }