mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-22 16:22:58 +02:00
Code Issues Releases Wiki Activity

[ticket/17535] Convert config files, make data providers static

Browse Source 
PHPBB-17535
This commit is contained in:
rxu
2025-07-16 17:36:45 +07:00
parent d7db296eab
commit 8a99024087
199 changed files with 879 additions and 852 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/migrations/migrations_check_config_added_test.php
View File

@@ -51,7 +51,7 @@ class migrations_check_config_added_test extends phpbb_test_case
$this->schema_data = file_get_contents($phpbb_root_path . 'install/schemas/schema_data.sql');
}
public function get_config_options_from_migrations()
protected function get_config_names()
{
global $phpbb_root_path, $phpEx;
@@ -154,18 +154,18 @@ class migrations_check_config_added_test extends phpbb_test_case
// Drop configuration options which were removed by config.remove
$config_names = array_diff_key($config_names, $config_removed);
return $config_names;
return array_combine(array_column($config_names, 0), array_column($config_names, 1));
}
/**
* @dataProvider get_config_options_from_migrations
*/
public function test_config_option_exists_in_schema_data($config_name, $class)
public function test_config_option_exists_in_schema_data()
{
$message = 'Migration: %1$s, config_name: %2$s; not added to schema_data.sql';
$this->assertNotFalse(strpos($this->schema_data, $config_name),
sprintf($message, $class, $config_name)
);
foreach ($this->get_config_names() as $config_name => $class)
{
$this->assertNotFalse(strpos($this->schema_data, $config_name),
sprintf($message, $class, $config_name)
);
}
}
}