1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 22:10:45 +02:00

Merge pull request #6248 from marc1706/ticket/16207

[ticket/16207] Require cookies for sessions
This commit is contained in:
Marc Alexander
2021-07-25 15:41:20 +02:00
committed by GitHub
24 changed files with 71 additions and 54 deletions

View File

@@ -184,7 +184,6 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c
$row_num = str_replace('redirect_expected_', '', $redirect);
$redirect = $crawler->filter('#redirect_' . $row_num)->text();
$redirect = substr($redirect, 0, strpos($redirect, 'sid') - 1);
$this->assertEquals($crawler->filter('#redirect_expected_' . $row_num)->text(), $redirect);
}

View File

@@ -34,6 +34,8 @@ class phpbb_functional_mcp_test extends phpbb_functional_test_case
*/
public function test_handle_quickmod($crawler)
{
$this->login();
// Test moving a post
return $this->get_quickmod_page(0, 'MERGE_POSTS', $crawler);
}
@@ -43,6 +45,8 @@ class phpbb_functional_mcp_test extends phpbb_functional_test_case
*/
public function test_move_post_to_topic($crawler)
{
$this->login();
// Select the post in MCP
$form = $crawler->selectButton($this->lang('SUBMIT'))->form(array(
'to_topic_id' => 1,

View File

@@ -39,12 +39,12 @@ class phpbb_build_url_test extends phpbb_test_case
array(
'index.php',
false,
'phpBB/index.php?',
'phpBB/index.php',
),
array(
'index.php',
't',
'phpBB/index.php?',
'phpBB/index.php',
),
array(
'viewtopic.php?t=5&f=4',
@@ -59,12 +59,12 @@ class phpbb_build_url_test extends phpbb_test_case
array(
'viewtopic.php?f=2&style=1&t=6',
array('f', 'style', 't'),
'phpBB/viewtopic.php?',
'phpBB/viewtopic.php',
),
array(
'http://test.phpbb.com/viewtopic.php?f=2&style=1&t=6',
array('f', 'style', 't'),
'http://test.phpbb.com/viewtopic.php?',
'http://test.phpbb.com/viewtopic.php',
),
array(
'posting.php?f=2&mode=delete&p=20%22%3Cscript%3Ealert%281%29%3B%3C%2Fscript%3E',

View File

@@ -22,6 +22,7 @@ class phpbb_mock_container_builder implements ContainerInterface
{
$this->setParameter('debug.load_time', false);
$this->setParameter('session.log_errors', false);
$this->setParameter('session.force_sid', true);
}
/**

View File

@@ -1396,7 +1396,7 @@ class phpbb_functional_test_case extends phpbb_test_case
}
$link = $crawler->filter('#quickmod')->selectLink($this->lang($action))->link()->getUri();
return self::request('GET', substr($link, strpos($link, 'mcp.')));
return self::request('GET', substr($link, strpos($link, 'mcp.')) . "&sid={$this->sid}");
}
/**