- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages)

- fixed cookie based topic tracking
- added missing config variables
- other minor things


git-svn-id: file:///svn/phpbb/trunk@5494 89ea8834-ac86-4346-8a33-228a782c2dd0

phpBB/includes/db/dbal.php

@@ -213,7 +213,16 @@ class dbal
 			}
 			else
 			{
-				$message .= '<br /><br />' . $user->lang['SQL_ERROR_OCCURRED'];
+				// If error occurs in initiating the session we need to use a pre-defined language string
+				// This could happen if the connection could not be established for example (then we are not able to grab the default language)
+				if (!isset($user->lang['SQL_ERROR_OCCURRED']))
+				{
+					$message .= '<br /><br />An sql error occurred while fetching this page. Please contact an administrator if this problem persist.';
+				}
+				else
+				{
+					$message .= '<br /><br />' . $user->lang['SQL_ERROR_OCCURRED'];
+				}
 			}
 
 			if ($this->transaction)

phpBB/includes/db/mysql.php

@@ -285,6 +285,14 @@ class dbal_mysql extends dbal
 	*/
 	function _sql_error()
 	{
+		if (!$this->db_connect_id)
+		{
+			return array(
+				'message'	=> @mysql_error(),
+				'code'		=> @mysql_errno()
+			);
+		}
+		
 		return array(
 			'message'	=> @mysql_error($this->db_connect_id),
 			'code'		=> @mysql_errno($this->db_connect_id)

phpBB/includes/db/mysql4.php

@@ -288,6 +288,14 @@ class dbal_mysql4 extends dbal
 	*/
 	function _sql_error()
 	{
+		if (!$this->db_connect_id)
+		{
+			return array(
+				'message'	=> @mysql_error(),
+				'code'		=> @mysql_errno()
+			);
+		}
+		
 		return array(
 			'message'	=> @mysql_error($this->db_connect_id),
 			'code'		=> @mysql_errno($this->db_connect_id)