mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 20:13:22 +01:00
Code Issues Releases Wiki Activity

Move add_log() call for captcha "configure" page to the captcha plugin, because only the plugin is able to know if the config got updated or not.

Browse Source 
Note to captcha MOD authors: please check if you have a function acp_page() and if an add_log() call is required for your plugin.
Bug #51695

git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10177 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Meik Sievertsen 2009-09-22 10:03:17 +00:00
parent 5d52b32a63
commit 90e1187601
4 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
phpBB/includes/acp/acp_captcha.php
View File

@ -31,7 +31,7 @@ class acp_captcha
include($phpbb_root_path . 'includes/captcha/captcha_factory.' . $phpEx); include($phpbb_root_path . 'includes/captcha/captcha_factory.' . $phpEx);
$captchas = phpbb_captcha_factory::get_captcha_types(); $captchas = phpbb_captcha_factory::get_captcha_types();
$selected = request_var('select_captcha', $config['captcha_plugin']); $selected = request_var('select_captcha', $config['captcha_plugin']);
$selected = (isset($captchas['available'][$selected]) || isset($captchas['unavailable'][$selected])) ? $selected : $config['captcha_plugin']; $selected = (isset($captchas['available'][$selected]) || isset($captchas['unavailable'][$selected])) ? $selected : $config['captcha_plugin'];
$configure = request_var('configure', false); $configure = request_var('configure', false);
@ -48,7 +48,6 @@ class acp_captcha
{ {
$config_captcha =& phpbb_captcha_factory::get_instance($selected); $config_captcha =& phpbb_captcha_factory::get_instance($selected);
$config_captcha->acp_page($id, $this); $config_captcha->acp_page($id, $this);
add_log('admin', 'LOG_CONFIG_VISUAL');
} }
else else
{ {

6
phpBB/includes/captcha/plugins/phpbb_captcha_gd_plugin.php
View File

@ -80,7 +80,7 @@ class phpbb_captcha_gd extends phpbb_default_captcha
{ {
return true; return true;
} }
function get_name() function get_name()
{ {
return 'CAPTCHA_GD'; return 'CAPTCHA_GD';
@ -123,6 +123,8 @@ class phpbb_captcha_gd extends phpbb_default_captcha
set_config($captcha_var, $value); set_config($captcha_var, $value);
} }
} }
add_log('admin', 'LOG_CONFIG_VISUAL');
trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($module->u_action)); trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($module->u_action));
} }
else if ($submit) else if ($submit)
@ -148,7 +150,7 @@ class phpbb_captcha_gd extends phpbb_default_captcha
function execute_demo() function execute_demo()
{ {
global $config; global $config;
$config_old = $config; $config_old = $config;
foreach ($this->captcha_vars as $captcha_var => $template_var) foreach ($this->captcha_vars as $captcha_var => $template_var)
{ {

1
phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php
View File

@ -685,6 +685,7 @@ class phpbb_captcha_qa
$this->acp_add_question($data); $this->acp_add_question($data);
} }
add_log('admin', 'LOG_CONFIG_VISUAL');
trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($list_url)); trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($list_url));
} }
} }

2
phpBB/includes/captcha/plugins/phpbb_recaptcha_plugin.php
View File

@ -100,6 +100,8 @@ class phpbb_recaptcha extends phpbb_default_captcha
set_config($captcha_var, $value); set_config($captcha_var, $value);
} }
} }
add_log('admin', 'LOG_CONFIG_VISUAL');
trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($module->u_action)); trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($module->u_action));
} }
else if ($submit) else if ($submit)