diff --git a/phpBB/admin/admin_groups.php b/phpBB/admin/admin_groups.php index b1f2517b7a..faad5502f4 100644 --- a/phpBB/admin/admin_groups.php +++ b/phpBB/admin/admin_groups.php @@ -136,8 +136,8 @@ if( isset($HTTP_POST_VARS['edit']) || isset($HTTP_POST_VARS['new']) ) "L_GROUP_HIDDEN" => $lang['group_hidden'], "L_GROUP_DELETE" => $lang['group_delete'], "L_GROUP_DELETE_CHECK" => $lang['group_delete_check'], - "L_SUBMIT" => $lang['submit_group_changes'], - "L_RESET" => $lang['reset_group_changes'], + "L_SUBMIT" => $lang['Submit'], + "L_RESET" => $lang['Reset'], "L_DELETE_MODERATOR" => $lang['delete_group_moderator'], "L_DELETE_MODERATOR_EXPLAIN" => $lang['delete_moderator_explain'], "L_YES" => $lang['Yes'], @@ -171,7 +171,7 @@ else if( isset($HTTP_POST_VARS['group_update']) ) message_die(GENERAL_ERROR, "Couldn't update group", "", __LINE__, __FILE__, $sql); } - $message = $lang['Deleted_group'] . "

" . sprintf($lang['return_group_admin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; + $message = $lang['Deleted_group'] . "

" . sprintf($lang['Click_return_groupsadmin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; message_die(GENERAL_MESSAGE, $message); } @@ -242,21 +242,28 @@ else if( isset($HTTP_POST_VARS['group_update']) ) message_die(GENERAL_ERROR, "Couldn't update group", "", __LINE__, __FILE__, $sql); } - $message = $lang['Updated_group'] . "

" . sprintf($lang['return_group_admin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; + $message = $lang['Updated_group'] . "

" . sprintf($lang['Click_return_groupsadmin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; message_die(GENERAL_MESSAGE, $message); } else if( $mode == "newgroup" ) { - - $sql = "INSERT INTO " . GROUPS_TABLE . " (group_type, group_name, group_description, group_moderator, group_single_user) - VALUES ('" . $group_type . "', '" . $group_name . "', '" . $group_description . "', '" . $group_moderator . "', '0')"; + $sql = "SELECT MAX(group_id) AS new_group_id + FROM " . GROUPS_TABLE; if ( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't insert new group", "", __LINE__, __FILE__, $sql); } + $row = $db->sql_fetchrow($result); - $new_group_id = $db->sql_nextid($result); + $new_group_id = $row['new_group_id'] + 1; + + $sql = "INSERT INTO " . GROUPS_TABLE . " (group_id, group_type, group_name, group_description, group_moderator, group_single_user) + VALUES ($new_group_id, '" . $group_type . "', '" . $group_name . "', '" . $group_description . "', '" . $group_moderator . "', '0')"; + if ( !$result = $db->sql_query($sql) ) + { + message_die(GENERAL_ERROR, "Couldn't insert new group", "", __LINE__, __FILE__, $sql); + } $sql = "INSERT INTO " . USER_GROUP_TABLE . " (group_id, user_id, user_pending) VALUES ($new_group_id, $group_moderator, 0)"; @@ -265,7 +272,7 @@ else if( isset($HTTP_POST_VARS['group_update']) ) message_die(GENERAL_ERROR, "Couldn't insert new user-group info", "", __LINE__, __FILE__, $sql); } - $message = $lang['Added_new_group'] . "

" . sprintf($lang['return_group_admin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; + $message = $lang['Added_new_group'] . "

" . sprintf($lang['Click_return_groupsadmin'], "", "") . "

" . sprintf($lang['Click_return_admin_index'], "", "");; message_die(GENERAL_MESSAGE, $message); diff --git a/phpBB/db/schemas/mssql_schema.sql b/phpBB/db/schemas/mssql_schema.sql index 7c42f87d87..6c39728549 100644 --- a/phpBB/db/schemas/mssql_schema.sql +++ b/phpBB/db/schemas/mssql_schema.sql @@ -89,7 +89,7 @@ CREATE TABLE [phpbb_forums] ( GO CREATE TABLE [phpbb_groups] ( - [group_id] [int] IDENTITY (1, 1) NOT NULL , + [group_id] [int] NOT NULL , [group_type] [smallint] NULL , [group_name] [varchar] (50) NOT NULL , [group_description] [varchar] (255) NOT NULL , diff --git a/phpBB/language/lang_english/lang_admin.php b/phpBB/language/lang_english/lang_admin.php index 6b6f276cd4..3a86f46dcb 100644 --- a/phpBB/language/lang_english/lang_admin.php +++ b/phpBB/language/lang_english/lang_admin.php @@ -440,7 +440,7 @@ $lang['No_group_moderator'] = "You must specify a moderator for this group"; $lang['No_group_mode'] = "You must specify a mode for this group, open or closed"; $lang['delete_group_moderator'] = "Delete the old group moderator?"; $lang['delete_moderator_explain'] = "If you're changing the group moderator, check this box to remove the old moderator from the group. Otherwise, do not check it, and the user will become a regular member of the group."; -$lang['return_group_admin'] = "Click %sHere%s to return to Group Administration."; +$lang['Click_return_groupsadmin'] = "Click %sHere%s to return to Group Administration."; $lang['Select_group'] = "Select a group"; $lang['Look_up_group'] = "Look up group";