mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/16955] Clean up code in db classes

Browse Source 
PHPBB3-16955
This commit is contained in:
Marc Alexander
2022-12-27 14:13:23 +01:00
parent 3bc100c9a0
commit 948023078b
26 changed files with 277 additions and 327 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpBB/phpbb/db/doctrine/oci8/connection.php
View File

@@ -68,7 +68,7 @@ class connection implements DriverConnection
/**
* {@inheritDoc}
*/
public function lastInsertId($name = null): ?string
public function lastInsertId($name = null)
{
return $this->wrapped->lastInsertId($name);
}

2
phpBB/phpbb/db/doctrine/table_helper.php
View File

@@ -21,7 +21,7 @@ class table_helper
*
* @param array $column_data Column data.
*
* @return array<string, array> A pair of type and array of column options.
* @return array{string, array} A pair of type and array of column options.
*/
public static function convert_column_data(array $column_data, string $dbms_layer): array
{

6
phpBB/phpbb/db/doctrine/type_converter.php
View File

@@ -54,7 +54,7 @@ class type_converter
*
* @param string $type Legacy type name
*
* @return array<string, array> Pair of type name and options.
* @return array{string, array} Pair of type name and options.
*/
public static function convert(string $type, string $dbms): array
{
@@ -73,7 +73,7 @@ class type_converter
* @param string $type Legacy type name.
* @param int $length Type length.
*
* @return array<string, array> Pair of type name and options.
* @return array{string, array} Pair of type name and options.
*/
private static function mapWithLength(string $type, int $length): array
{
@@ -107,7 +107,7 @@ class type_converter
*
* @param string $type Type name.
*
* @return array<string, array> Pair of type name and an array of options.
* @return array{string, array} Pair of type name and an array of options.
*/
private static function mapType(string $type, string $dbms): array
{