mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/9061] Simplify conditional statements by reworking the logic.

Browse Source 
PHPBB3-9061
This commit is contained in:
Chris Smith
2010-09-09 20:05:11 +01:00
parent 01ef46a510
commit 9819700247
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
phpBB/includes/functions_messenger.php
View File

@@ -647,25 +647,31 @@ class queue
{
$mode = 'wb';
}
$lock_fp = @fopen($this->cache_file . '.lock', $mode);
// Two processes may attempt to create lock file at the same time.
// Have the losing process try opening the lock file again for reading
// on the assumption that the winning process created it
if (!$lock_fp && $mode == 'wb')
if ($mode == 'wb')
{
// Assign to $mode for the check in chmod below
$mode = 'rb';
$lock_fp = @fopen($this->cache_file . '.lock', $mode);
}
if ($lock_fp && $mode == 'wb')
{
// Only need to set mode when the lock file is written
@chmod($this->cache_file . '.lock', 0666);
if (!$lock_fp)
{
// Two processes may attempt to create lock file at the same time.
// Have the losing process try opening the lock file again for reading
// on the assumption that the winning process created it
$mode = 'rb';
$lock_fp = @fopen($this->cache_file . '.lock', $mode);
}
else
{
// Only need to set mode when the lock file is written
@chmod($this->cache_file . '.lock', 0666);
}
}
if ($lock_fp)
{
@flock($lock_fp, LOCK_EX);
}
return $lock_fp;
}