From 9dc5c9271a3518b829b5f8d858a61c2a936538a2 Mon Sep 17 00:00:00 2001 From: Andreas Fischer Date: Fri, 1 Jan 2010 23:39:31 +0000 Subject: [PATCH] Fix Bug #56125 - XHTML mistakes in Coding Guidelines. Patch by leviatan21. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10395 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/docs/coding-guidelines.html | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/phpBB/docs/coding-guidelines.html b/phpBB/docs/coding-guidelines.html index 8ac2e4e89d..7f747e09e2 100644 --- a/phpBB/docs/coding-guidelines.html +++ b/phpBB/docs/coding-guidelines.html @@ -69,7 +69,7 @@
  • General Guidelines
    • -
  • Styling
    • +
  • Styling
    1. Style Config Files
    2. General Styling Rules
      3. @@ -125,7 +125,7 @@

      If entered with tabs (replace the {TAB}) both equal signs need to be on the same column.

      Linefeeds:

      -

      Ensure that your editor is saving files in the UNIX (LF) line ending format. This means that lines are terminated with a newline, not with Windows Line endings (CR/LF combo) as they are on Win32 or Classic Mac (CR) Line endings. Any decent editor should be able to do this, but it might not always be the default setting. Know your editor. If you want advice for an editor for your Operating System, just ask one of the developers. Some of them do their editing on Win32. +

      Ensure that your editor is saving files in the UNIX (LF) line ending format. This means that lines are terminated with a newline, not with Windows Line endings (CR/LF combo) as they are on Win32 or Classic Mac (CR) Line endings. Any decent editor should be able to do this, but it might not always be the default setting. Know your editor. If you want advice for an editor for your Operating System, just ask one of the developers. Some of them do their editing on Win32.

      1.ii. File Header

      @@ -203,7 +203,7 @@ class ...
    3. /includes/db/firebird.php
      Firebird/Interbase Database Abstraction Layer
    4. /includes/db/msssql.php
      MSSQL Database Abstraction Layer
    5. /includes/db/mssql_odbc.php
      MSSQL ODBC Database Abstraction Layer for MSSQL
      6. -
    6. /includes/db/mysql.php
      MySQL Database Abstraction Layer for MySQL 3.x/4.0.x/4.1.x/5.x +
    7. /includes/db/mysql.php
      MySQL Database Abstraction Layer for MySQL 3.x/4.0.x/4.1.x/5.x
    8. /includes/db/mysqli.php
      MySQLi Database Abstraction Layer
    9. /includes/db/oracle.php
      Oracle Database Abstraction Layer
    10. /includes/db/postgres.php
      PostgreSQL Database Abstraction Layer
      11. @@ -224,7 +224,7 @@ class ...
    11. styles
      /styles, style.php
      phpBB Styles/Templates/Themes/Imagesets
      12. - 1.iv. Special Constants +

      1.iv. Special Constants

      There are some special constants application developers are able to utilize to bend some of phpBB's internal functionality to suit their needs.

      @@ -1170,24 +1170,13 @@ append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=group&amp; <!-- INCLUDE {FILE_VAR} --> -

      Template defined variables can also be utilised. +

      Template defined variables can also be utilised.

       <!-- DEFINE $SOME_VAR = 'my_file.html' -->
 <!-- INCLUDE {$SOME_VAR} -->
      -

      PHP

      A contentious decision has seen the ability to include PHP within the template introduced. This is achieved by enclosing the PHP within relevant tags:

      @@ -1541,11 +1530,11 @@ div <form method="post" id="mcp" action="{U_POST_ACTION}"> <fieldset class="submit-buttons"> - <input type="reset" value="{L_RESET}" name="reset" class="button2" />  - <input type="submit" name="action[add_warning]" value="{L_SUBMIT}" class="button1" /> + <input type="reset" value="{L_RESET}" name="reset" class="button2" />  + <input type="submit" name="action[add_warning]" value="{L_SUBMIT}" class="button1" /> {S_FORM_TOKEN} - </fieldset> -</form> + </fieldset> +</form>

      4.ii. Template Inheritance

      @@ -2337,7 +2326,7 @@ if (utf8_case_fold_nfc($string1) == utf8_case_fold_nfc($string2))
      -

      The version control system for phpBB3 is subversion. The repository is available at http://code.phpbb.com/svn/phpbb. +

      The version control system for phpBB3 is subversion. The repository is available at http://code.phpbb.com/svn/phpbb.

      7.i. Repository Structure