Merge pull request #3514 from CHItA/ticket/13740

[ticket/13740] Refactoring installer

* CHItA/ticket/13740: (75 commits)
  [ticket/13740] Reduce number of references in nav provider
  [ticket/13740] Move handle_language_select calls to the controllers
  [ticket/13740] Fix infinite config.php check loop
  [ticket/13740] Move default data settings out of constructors
  [ticket/13740] Deduplicate container builder's checks
  [ticket/13740] Use JSON for installer config
  [ticket/13740] Fix comment
  [ticket/13740] Use language service in console application
  [ticket/13740] Fix CS in compatibilty_globals.php
  [ticket/13740] Fix message element creation in JS
  [ticket/13740] Replace more spaces with tabs
  [ticket/13740] Fix CS
  [ticket/13740] Filter basic directory change attempts in lang change
  [ticket/13740] Use tabs instead of spaces in JS file
  [ticket/13740] Add success message when install finished
  [ticket/13740] Fix $script_path in obtain_data
  [ticket/13740] Fix is_phpbb_installed() method
  [ticket/13740] Login admin when install finished
  [ticket/13740] Enhance server output buffer bypass
  [ticket/13740] Secure installer config against corrupted config data
  ...

phpBB/config/default/container/services.yml

@@ -8,13 +8,16 @@ imports:
     - { resource: services_db.yml }
     - { resource: services_event.yml }
     - { resource: services_feed.yml }
+    - { resource: services_files.yml }
     - { resource: services_help.yml }
+    - { resource: services_http.yml }
     - { resource: services_language.yml }
     - { resource: services_migrator.yml }
     - { resource: services_mimetype_guesser.yml }
     - { resource: services_module.yml }
     - { resource: services_notification.yml }
     - { resource: services_password.yml }
+    - { resource: services_php.yml }
     - { resource: services_profilefield.yml }
     - { resource: services_report.yml }
     - { resource: services_routing.yml }
@@ -107,19 +110,9 @@ services:
             - %core.php_ext%
             - @cache.driver
 
-    filesystem:
-        class: phpbb\filesystem\filesystem
-
     file_downloader:
         class: phpbb\file_downloader
 
-    http_kernel:
-        class: Symfony\Component\HttpKernel\HttpKernel
-        arguments:
-            - @dispatcher
-            - @controller.resolver
-            - @request_stack
-
     log:
         class: phpbb\log\log
         arguments:
@@ -142,9 +135,6 @@ services:
             - %core.php_ext%
             - %core.adm_relative_path%
 
-    php_ini:
-        class: phpbb\php\ini
-
     plupload:
         class: phpbb\plupload\plupload
         arguments:
@@ -155,22 +145,6 @@ services:
             - @php_ini
             - @mimetype.guesser
 
-    request:
-        class: phpbb\request\request
-        arguments:
-            - null
-            - %core.disable_super_globals%
-
-    # WARNING: The Symfony request does not escape the input and should be used very carefully
-    #           prefer the phpbb request (service @request) as possible
-    symfony_request:
-        class: phpbb\symfony_request
-        arguments:
-            - @request
-
-    request_stack:
-        class: Symfony\Component\HttpFoundation\RequestStack
-
     upload_imagesize:
         class: fastImageSize\fastImageSize
 

phpBB/config/default/container/services_files.yml

@@ -0,0 +1,3 @@
+services:
+    filesystem:
+        class: phpbb\filesystem\filesystem

phpBB/config/default/container/services_http.yml

@@ -0,0 +1,23 @@
+services:
+    http_kernel:
+        class: Symfony\Component\HttpKernel\HttpKernel
+        arguments:
+            - @dispatcher
+            - @controller.resolver
+            - @request_stack
+
+    # WARNING: The Symfony request does not escape the input and should be used very carefully
+    #           prefer the phpbb request (service @request) as possible
+    symfony_request:
+        class: phpbb\symfony_request
+        arguments:
+            - @request
+
+    request_stack:
+        class: Symfony\Component\HttpFoundation\RequestStack
+
+    request:
+        class: phpbb\request\request
+        arguments:
+            - null
+            - %core.disable_super_globals%

phpBB/config/default/container/services_php.yml

@@ -0,0 +1,3 @@
+services:
+    php_ini:
+        class: phpbb\php\ini

phpBB/config/default/container/tables.yml

@@ -11,6 +11,7 @@ parameters:
     tables.forums: %core.table_prefix%forums
     tables.log: %core.table_prefix%log
     tables.migrations: %core.table_prefix%migrations
+    tables.moderator_cache: %core.table_prefix%moderator_cache
     tables.modules: %core.table_prefix%modules
     tables.notification_types: %core.table_prefix%notification_types
     tables.notifications: %core.table_prefix%notifications