[feature/request-class] Add is_secure method to request for HTTPS

PHPBB3-9716

phpBB/includes/request/interface.php

@@ -121,6 +121,13 @@ interface phpbb_request_interface
 	*/
 	public function is_ajax();
 
+	/**
+	* Checks if the current request is happening over HTTPS.
+	*
+	* @return	bool			True if the request is secure.
+	*/
+	public function is_secure();
+
 	/**
 	* Returns all variable names for a given super global
 	*

phpBB/includes/request/request.php

@@ -326,6 +326,16 @@ class phpbb_request implements phpbb_request_interface
 		return $this->header('X-Requested-With') == 'XMLHttpRequest';
 	}
 
+	/**
+	* Checks if the current request is happening over HTTPS.
+	*
+	* @return	bool			True if the request is secure.
+	*/
+	public function is_secure()
+	{
+		return $this->server('HTTPS') == 'on';
+	}
+
 	/**
 	* Returns all variable names for a given super global
 	*

tests/mock/request.php

@@ -57,6 +57,11 @@ class phpbb_mock_request implements phpbb_request_interface
 		return false;
 	}
 
+	public function is_secure()
+	{
+		return false;
+	}
+
 	public function variable_names($super_global = phpbb_request_interface::REQUEST)
 	{
 		return array_keys($this->data[$super_global]);

tests/request/request_test.php

@@ -117,6 +117,17 @@ class phpbb_request_test extends phpbb_test_case
 		$this->assertTrue($this->request->is_ajax());
 	}
 
+	public function test_is_secure()
+	{
+		$this->assertFalse($this->request->is_secure());
+
+		$this->request->enable_super_globals();
+		$_SERVER['HTTPS'] = 'on';
+		$this->request = new phpbb_request($this->type_cast_helper);
+
+		$this->assertTrue($this->request->is_secure());
+	}
+
 	public function test_variable_names()
 	{
 		$expected = array('test', 'unset');