mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 12:03:21 +01:00
Code Issues Releases Wiki Activity

[ticket/12575] Speed up load_class()

Browse Source 
Load the services referenced in a service_collection only when
they are used to avoid to load some unsuded services.

PHPBB3-12575
This commit is contained in:
Tristan Darricau 2014-05-21 22:24:48 +02:00
parent 7642fbbd63
commit a4c15bbf4f
1 changed files with 78 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
phpBB/phpbb/di/service_collection.php
View File

@ -30,6 +30,28 @@ class service_collection extends \ArrayObject
$this->container = $container; $this->container = $container;
} }
/**
* {@inheritdoc}
*/
public function getIterator()
{
return new service_collection_iterator($this->container, $this);
}
/**
* {@inheritdoc}
*/
public function offsetGet($index)
{
if (($task = parent::offsetGet($index)) == null)
{
$task = $this->container->get($index);
$this->offsetSet($index, $task);
}
return $task;
}
/** /**
* Add a service to the collection * Add a service to the collection
* *
@ -38,8 +60,61 @@ class service_collection extends \ArrayObject
*/ */
public function add($name) public function add($name)
{ {
$task = $this->container->get($name); $this->offsetSet($name, null);
}
$this->offsetSet($name, $task); }
/**
* Iterator which load the services when they are requested
*
* @package phpBB3
*/
class service_collection_iterator extends \ArrayIterator
{
protected $container;
/**
* Construct an ArrayIterator for service_collection
*
* @param ContainerInterface $container Container object
* @param array $array The array or object to be iterated on.
* @param int $flags Flags to control the behaviour of the ArrayObject object.
* @see ArrayObject::setFlags()
*/
public function __construct(ContainerInterface $container, $array = array() , $flags = 0)
{
parent::__construct($array, $flags);
$this->container = $container;
}
/**
* {@inheritdoc}
*/
public function offsetGet($index)
{
if (($task = parent::offsetGet($index)) == null)
{
$task = $this->container->get($index);
$this->offsetSet($index, $task);
}
return $task;
}
/**
* {@inheritdoc}
*/
public function current()
{
if (($task = parent::current()) == null)
{
$name = $this->key();
$task = $this->container->get($name);
$this->offsetSet($name, $task);
}
return $task;
} }
} }