mirror of
https://github.com/phpbb/phpbb.git
synced 2025-08-13 04:04:12 +02:00
Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11850
# By Nils Adermann (68) and others # Via Andreas Fischer (12) and others * 'develop' of github.com:phpbb/phpbb3: (102 commits) [ticket/11876] Replace MD5 with SHA256. [ticket/11876] Move checksum generation from build PHP files to phing build.xml [develop-olympus] Build against 3.0.12 instead of 3.0.12-RC3. Tag exists now. [prep-release-3.0.12] Update changelog for 3.0.12 release. [ticket/11873] Add unit test for large password input. [ticket/11873] Do not hash very large passwords in order to safe resources. [ticket/11862] Correct var names in user_delete() events due to prune-users [develop-olympus] Use 3.0.13-dev as build version. Use latest 3.0.12 RC tag. [prep-release-3.0.12] Bumping version number for 3.0.12 final. [ticket/11852] Add class file [ticket/11852] Move tests to folder with new class name [ticket/11852] Split filesystem and path_helper into 2 classes [ticket/11868] Add @depends to test [ticket/11868] Add functional test for registration [ticket/11868] Replace phpbb_request_interface references [ticket/11866] Only single backslash in .md files [ticket/11866] Remove outdated and broken develop script [ticket/11866] More namespaces [ticket/11866] Update some occurances of phpbb_db_ to new Namespace [ticket/11865] Convert old class name to namespaced version ... Conflicts: tests/security/extract_current_page_test.php tests/session/testable_facade.php
This commit is contained in:
@@ -14,11 +14,11 @@ require_once dirname(__FILE__) . '/../../phpBB/phpbb/session.php';
|
||||
* This class exists to expose session.php's functions in a more testable way.
|
||||
*
|
||||
* Since many functions in session.php have global variables inside the function,
|
||||
* this exposes those functions through a testable facade that uses
|
||||
* testable_factory's mock global variables to modify global variables used in
|
||||
* this exposes those functions through a testable facade that uses
|
||||
* testable_factory's mock global variables to modify global variables used in
|
||||
* the functions.
|
||||
*
|
||||
* This is using the facade pattern to provide a testable "front" to the
|
||||
* This is using the facade pattern to provide a testable "front" to the
|
||||
* functions in sessions.php.
|
||||
*
|
||||
*/
|
||||
@@ -43,8 +43,8 @@ class phpbb_session_testable_facade
|
||||
global $config, $request;
|
||||
$config['server_name'] = $server_name_config;
|
||||
$config['cookie_domain'] = $cookie_domain_config;
|
||||
$request->overwrite('SERVER_NAME', $host, phpbb_request_interface::SERVER);
|
||||
$request->overwrite('Host', $host, phpbb_request_interface::SERVER);
|
||||
$request->overwrite('SERVER_NAME', $host, \phpbb\request\request_interface::SERVER);
|
||||
$request->overwrite('Host', $host, \phpbb\request\request_interface::SERVER);
|
||||
// Note: There is a php_uname function used as a fallthrough
|
||||
// that this function doesn't override
|
||||
return $session->extract_current_hostname();
|
||||
@@ -120,7 +120,7 @@ class phpbb_session_testable_facade
|
||||
$session->host = $host;
|
||||
$config['force_server_vars'] = $force_server_vars;
|
||||
$config['server_name'] = $server_name;
|
||||
$request->overwrite('SERVER_PORT', $server_port, phpbb_request_interface::SERVER);
|
||||
$request->overwrite('SERVER_PORT', $server_port, \phpbb\request\request_interface::SERVER);
|
||||
return $session->validate_referer($check_script_path);
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user