ok, handled some bugs... the most important being validate_username (the variable passed to validate_data([...]array('username', [...])) and updating group listings while doing relevant group actions. Oh, and PM icons are working now. :o

git-svn-id: file:///svn/phpbb/trunk@6894 89ea8834-ac86-4346-8a33-228a782c2dd0

phpBB/includes/ucp/ucp_groups.php

@@ -799,7 +799,6 @@ class ucp_groups
 								group_user_attributes('default', $group_id, $mark_ary, false, $group_row['group_name'], $group_row);
 							}
 
-							group_update_listings($group_id);
 							$user->add_lang('acp/groups');
 
 							trigger_error($user->lang['GROUP_DEFS_UPDATED'] . $return_page);

phpBB/includes/ucp/ucp_pm_compose.php

@@ -558,7 +558,7 @@ function compose_pm($id, $mode, $action)
 			unset($message_parser);
 
 			// ((!$message_subject) ? $subject : $message_subject)
-			$msg_id = submit_pm($action, $subject, $pm_data, true);
+			$msg_id = submit_pm($action, $subject, $pm_data);
 
 			$return_message_url = append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&mode=view&p=' . $msg_id);
 			$return_folder_url = append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&folder=outbox');

phpBB/includes/ucp/ucp_pm_viewfolder.php

@@ -239,7 +239,9 @@ function view_folder($id, $mode, $folder_id, $folder)
 
 			$template->assign_vars(array(
 				'S_SHOW_RECIPIENTS'		=> ($folder_id == PRIVMSGS_OUTBOX || $folder_id == PRIVMSGS_SENTBOX) ? true : false,
-				'S_SHOW_COLOUR_LEGEND'	=> true)
+				'S_SHOW_COLOUR_LEGEND'	=> true,
+
+				'S_PM_ICONS'			=> ($config['enable_pm_icons']) ? true : false)
 			);
 		}
 	}

phpBB/includes/ucp/ucp_profile.php

@@ -60,7 +60,7 @@ class ucp_profile
 					{
 						$check_ary['username'] = array(
 							array('string', false, $config['min_name_chars'], $config['max_name_chars']),
-							array('username', $data['username']),
+							array('username'),
 						);
 					}