mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-10-12 23:44:32 +02:00
Code Issues Releases Wiki Activity

[ticket/15085] Output login error with attempts info in http auth

Browse Source 
PHPBB-15085
This commit is contained in:
Marc Alexander
2025-10-07 19:44:01 +02:00
parent 033fb28fdc
commit a9b62f338a
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpBB/phpbb/feed/event/http_auth_subscriber.php
View File

@@ -118,7 +118,7 @@ class http_auth_subscriber implements EventSubscriberInterface
else if ($auth_result['status'] == LOGIN_ERROR_ATTEMPTS) else if ($auth_result['status'] == LOGIN_ERROR_ATTEMPTS)
{ {
// Too many login attempts // Too many login attempts
$response = new Response($this->language->lang('NOT_AUTHORISED'), Response::HTTP_UNAUTHORIZED); $response = new Response($this->language->lang('LOGIN_ERROR_ATTEMPTS'), Response::HTTP_UNAUTHORIZED);
$event->setResponse($response); $event->setResponse($response);
return; return;
} }

3
tests/feed/http_auth_subscriber_test.php
View File

@@ -62,6 +62,7 @@ class phpbb_feed_http_auth_subscriber_test extends \phpbb_test_case
$this->language->method('lang') $this->language->method('lang')
->willReturnMap([ ->willReturnMap([
['NOT_AUTHORISED', 'NOT_AUTHORISED'], ['NOT_AUTHORISED', 'NOT_AUTHORISED'],
['LOGIN_ERROR_ATTEMPTS', 'LOGIN_ERROR_ATTEMPTS']
]); ]);
$this->request = $this->getMockBuilder('\phpbb\request\request_interface') $this->request = $this->getMockBuilder('\phpbb\request\request_interface')
@@ -414,7 +415,7 @@ class phpbb_feed_http_auth_subscriber_test extends \phpbb_test_case
$this->subscriber->on_kernel_request($event); $this->subscriber->on_kernel_request($event);
$this->assertEquals(Response::HTTP_UNAUTHORIZED, $response->getStatusCode()); $this->assertEquals(Response::HTTP_UNAUTHORIZED, $response->getStatusCode());
$this->assertEquals('NOT_AUTHORISED', $response->getContent()); $this->assertEquals('LOGIN_ERROR_ATTEMPTS', $response->getContent());
$this->assertFalse($response->headers->has('WWW-Authenticate')); $this->assertFalse($response->headers->has('WWW-Authenticate'));
} }