From c98193a799067896e61b0df615fe49bc48814048 Mon Sep 17 00:00:00 2001 From: rxu Date: Sun, 8 Jan 2017 22:16:40 +0700 Subject: [PATCH 1/2] [ticket/14971] Fix pagination PHP warning on PHP 7.1 PHPBB3-14971 --- phpBB/phpbb/pagination.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/phpbb/pagination.php b/phpBB/phpbb/pagination.php index 7a81c25ad2..a5a95b096d 100644 --- a/phpBB/phpbb/pagination.php +++ b/phpBB/phpbb/pagination.php @@ -284,7 +284,7 @@ class pagination */ public function get_on_page($per_page, $start) { - return floor($start / $per_page) + 1; + return floor((int) $start / (int) $per_page) + 1; } /** From 06b402bdecee8145639d50d17e1350971a5ec017 Mon Sep 17 00:00:00 2001 From: rxu Date: Sun, 8 Jan 2017 23:07:08 +0700 Subject: [PATCH 2/2] [ticket/14971] Add on_page test with the string arguments PHPBB3-14971 --- tests/pagination/pagination_test.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/pagination/pagination_test.php b/tests/pagination/pagination_test.php index 30b25913f7..2d7d1671a8 100644 --- a/tests/pagination/pagination_test.php +++ b/tests/pagination/pagination_test.php @@ -219,6 +219,12 @@ class phpbb_pagination_pagination_test extends phpbb_template_template_test_case 0, 'PAGE_OF-1-1', ), + array( + '10', + '10', + '0', + 'PAGE_OF-1-1', + ), ); }